refactor(inputfield): use inputlabel and re-export as subcomp #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinlee93
force-pushed
the
jlee/mergeTogetherInputFieldComponents
branch
from
5da63be to
789b986
Compare
Codecov Report
@@ Coverage Diff @@
## feature/EFI-1219 #1699 +/- ##
====================================================
+ Coverage 92.76% 92.77% +0.01%
====================================================
Files 158 159 +1
Lines 2779 2783 +4
Branches 716 717 +1
====================================================
+ Hits 2578 2582 +4
Misses 184 184
Partials 17 17
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jinlee93
force-pushed
the
jlee/mergeTogetherInputFieldComponents
branch
from
789b986 to
54149ad
Compare
|
Also filed EFI-1250 for similar treatment for TextArea |
booc0mtaco
approved these changes
Jul 18, 2023
booc0mtaco
pushed a commit
that referenced
this pull request
Jul 19, 2023
* refactor(inputfield): use inputlabel and re-export as subcomp * docs(inputfield): add comment spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EFI-1228
Summary:
Inputcomponent as its not a subcomponent for justInputFieldand possibly has use as utility component in other areasInputLabelcomponent overLabelcomponent be in line withCheckboxandRadioTest Plan: