docs(Modal): add clarity on how to use open prop #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Link to relevant HeadlessUI documentation - Add recommendations for how to use with inline examples - Typo and other documentation improvements
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## next #1705 +/- ##
=======================================
Coverage 92.63% 92.63%
=======================================
Files 155 155
Lines 2785 2785
Branches 725 725
=======================================
Hits 2580 2580
Misses 188 188
Partials 17 17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jinlee93
reviewed
Jul 21, 2023
| @@ -8,7 +8,7 @@ import Heading from '../Heading'; | |||
| import { Icon } from '../Icon/Icon'; | |||
| import styles from './Modal.module.css'; | |||
|
|
|||
| type Variant = 'brand' | undefined; | |||
| type Variant = 'brand'; | |||
jinlee93
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: