Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(omlet): only scan components in src directory #1710

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

booc0mtaco
Copy link
Contributor

Summary:

this prevents bifurcation of components so that it doesn't confuse built versions with their typescript equivalents

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Manually tested my changes, and here are the details:
    • validate scan result using --dry-run

@booc0mtaco booc0mtaco requested a review from a team July 24, 2023 22:38
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #1710 (eabcabf) into next (891129e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1710   +/-   ##
=======================================
  Coverage   92.63%   92.63%           
=======================================
  Files         155      155           
  Lines        2785     2785           
  Branches      725      725           
=======================================
  Hits         2580     2580           
  Misses        188      188           
  Partials       17       17           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

size-limit report 📦

Path Size
components 102.76 KB (0%)
styles 37.51 KB (+5.24% 🔺)

@booc0mtaco booc0mtaco merged commit 8cc4189 into next Jul 24, 2023
@booc0mtaco booc0mtaco deleted the aholloway/x-update-omlet-config branch July 24, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants