-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: split t3 colors stories and remove t3 stories aggregator #1720
Conversation
} | ||
return value; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this util function recurses to the raw value
@@ -1,10 +1,19 @@ | |||
import tokens from '../data/tokens.json'; | |||
|
|||
const recurseToPrimaryValue: (value: string) => string = (value) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## next #1720 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 146 146
Lines 2579 2579
Branches 664 664
=======================================
Hits 2380 2380
Misses 198 198
Partials 1 1 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
size-limit report 📦
|
Now that we have quite a few different values in here, I think labeling them in the UI would be helpful. We could widen the text area for these, and put them in a table or something.
|
Updated to have a Table which also affected the T1 and T2 colors appropriately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jinlee93 Looks great to me, and good call on sticky header :P
Summary:
Test Plan: