thuang-fix-deps #1020
Closed
thuang-fix-deps #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tihuan
force-pushed
the
thuang-fix-deps
branch
2 times, most recently
from
e6bca0b to
f4aae17
Compare
Bento007
approved these changes
Mar 26, 2021
Codecov Report
@@ Coverage Diff @@
## main #1020 +/- ##
=======================================
Coverage 94.28% 94.28%
=======================================
Files 73 73
Lines 4476 4476
=======================================
Hits 4220 4220
Misses 256 256
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Actually I will wait to merge this after Next.js PR is in to avoid merge conflicts. Thank you! |
|
Ah good news! Using Next.js automatically resolves all the vulnerability issues 🎉 So we can close this PR now 💪 Thank you! CC: @maniarathi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
Functional:
@Bento007
Readability:
@maniarathi
Changes
This PR addresses two High Severity deps through forcing resolution to use the patched versions:
https://github.com/chanzuckerberg/corpora-data-portal/security/dependabot/frontend/package-lock.json/ssri/open
https://github.com/chanzuckerberg/corpora-data-portal/security/dependabot/frontend/package-lock.json/is-svg/open<-- turned out this one is not easy to fix. And since it's rooted from using Gatsby, we can see if the problem just goes away when we migrate to Next.js!PTAL thank you!
Definition of Done (from ticket)
QA steps (optional)