Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

feat: count column for druid supports float now #1075

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

kartikay-bagla
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for frontend-sb canceled.

Name Link
🔨 Latest commit b3b0e3b
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/62e956ac706f190009f58ea0

@gitpod-io
Copy link

gitpod-io bot commented Aug 2, 2022

Copy link
Contributor

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally with a Druid dataset that has a count column of type DOUBLE. Anomaly and DD works. Also checked that the same KPI did not pass validation before these changes.

@manassolanki
Copy link
Member

@kartikay-bagla @Samyak2 Have we also tested the Anomaly and DD output as well for this? Also, can we cross-check once that this won't create any side-effects in any of our algorithms (where we might be assuming count as int only)?

@manassolanki manassolanki merged commit 4297aac into develop Aug 5, 2022
@Samyak2 Samyak2 added this to the v0.10.1 milestone Aug 11, 2022
@Samyak2 Samyak2 deleted the feat/druid-count-col-float branch August 11, 2022 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants