Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

fix(retrain): clear recent alerts data and set appropriate last_anomaly_timestamp #1128

Merged
merged 1 commit into from
Sep 27, 2022
Merged

fix(retrain): clear recent alerts data and set appropriate last_anomaly_timestamp #1128

merged 1 commit into from
Sep 27, 2022

Conversation

Samyak2
Copy link
Contributor

@Samyak2 Samyak2 commented Sep 21, 2022

Changes

  • Before re-training, the triggered alerts data from T-offset is deleted and the last_anomaly_timestamp is set to one unit lesser than T-offset (unit depends on the anomaly frequency).

Notes for reviewers

  • See new functions: clear_triggered_alerts_from_offset, set_last_anomaly_timestamp_to_offset
  • See new code in kpi_anomaly_retraining in anomaly_data_view

Testing

  • Daily KPI - lyft - individual alert. Alert gets triggered everytime re-training is done. The alert has data for T-offset only.
  • Hourly KPI - cloud cost - individual alert. Alert gets triggered everytime re-training is done. The alert has data for all hours of today.

@Samyak2 Samyak2 added 🛠️ backend ❗alerts Alert formatting, scheduling, etc. labels Sep 21, 2022
@Samyak2 Samyak2 added this to the v0.11.0 milestone Sep 21, 2022
@Samyak2 Samyak2 requested a review from Amatullah September 21, 2022 11:45
@gitpod-io
Copy link

gitpod-io bot commented Sep 21, 2022

@netlify
Copy link

netlify bot commented Sep 21, 2022 •
edited
Loading

✅ Deploy Preview for frontend-sb canceled.

Name Link
🔨 Latest commit 2263dee
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/632af943722d0700092e4694

Amatullah
Amatullah approved these changes Sep 25, 2022
View reviewed changes
Copy link
Member

@Amatullah Amatullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Samyak2 Samyak2 merged commit 4ed7f70 into develop Sep 27, 2022
@Samyak2 Samyak2 deleted the fix/alerts-in-anomaly-retrain branch September 27, 2022 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Amatullah Amatullah Amatullah approved these changes

@manassolanki manassolanki Awaiting requested review from manassolanki

Assignees
No one assigned
Labels
❗alerts Alert formatting, scheduling, etc. 🛠️ backend
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Samyak2 @Amatullah