ci: fix cache path calculation

[YangKeao]

Signed-off-by: YangKeao yangkeao@chunibyo.icu

Recent e2e test image build doesn't hit the cache, because of a bug in calculating the cache directory 😢 This PR solves two problems:

1. The fake_image targets should depend on build-env, but not dev-env.
2. The cache directory should be joined with an image name directory.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• STRRL
• cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[YangKeao]

/run-e2e-tests

[YangKeao]

/run-e2e-tests

[YangKeao]

/run-e2e-tests

[YangKeao]

/run-e2e-tests

[YangKeao]

/run-e2e-tests

[codecov]

Codecov Report

Merging #2792 (d8c1641) into master (d37823e) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2792      +/-   ##
==========================================
- Coverage   40.93%   40.82%   -0.12%     
==========================================
  Files         144      144              
  Lines       11747    11747              
==========================================
- Hits         4809     4796      -13     
- Misses       6574     6587      +13     
  Partials      364      364              

Impacted Files	Coverage Δ
.../workflow/controllers/workflow_entry_reconciler.go	48.14% <0.00%> (-4.77%)	⬇️
pkg/selector/generic/mode.go	25.64% <0.00%> (-2.57%)	⬇️
pkg/workflow/controllers/utils.go	85.71% <0.00%> (-1.59%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d37823e...d8c1641. Read the comment docs.

[YangKeao]

/run-e2e-tests

[YangKeao]

/run-e2e-tests

[YangKeao]

/run-e2e-tests

[YangKeao]

/run-e2e-tests

[STRRL]

LGTM!

[STRRL]

Should this PR be cheery-picked to release-2.1?

[YangKeao]

Should this PR be cheery-picked to release-2.1?

No. build-script is only merged on master (which is expected, I think)

[cwen0]

LGTM

[cwen0]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: d1dd647