JVMChaos: support inject fault into MySQL client #3189
Conversation
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #3189 +/- ##
==========================================
+ Coverage 40.84% 40.93% +0.08%
==========================================
Files 164 164
Lines 13798 13830 +32
==========================================
+ Hits 5636 5661 +25
- Misses 7735 7740 +5
- Partials 427 429 +2
Continue to review full report at Codecov.
|
WangXiangUSTC
force-pushed
the
jvmchaos_mysql
branch
from
e0f7e93
to
ec09b46
Compare
WangXiangUSTC
force-pushed
the
jvmchaos_mysql
branch
from
ec09b46
to
5edc1b7
Compare
| // SQL is "select * from test.t1", | ||
| // only when ((Database == "test" || Database == "") && (Table == "t1" || Table == "") && (SQLType == "select" || SQLType == "")) is true, JVMChaos will inject fault | ||
| type JVMMySQLSpec struct { | ||
| // the version of mysql-connector-java, only support 5.X.X(set to 5) and 8.X.X(set to 8) now |
There was a problem hiding this comment.
| // the version of mysql-connector-java, only support 5.X.X(set to 5) and 8.X.X(set to 8) now | |
| // the version of mysql-connector-java, only support 5.X.X(set to "5") and 8.X.X(set to "8") now |
using a double quote to emphasize here requires a string
api/v1alpha1/jvmchaos_webhook.go
Outdated
| if len(in. MySQLConnectorVersion) == 0 { | ||
| allErrs = append(allErrs, field.Invalid(path, in, "MySQL connector version not provided")) | ||
| } |
There was a problem hiding this comment.
also check the version could only be "5" or "8"?
api/v1alpha1/jvmchaos_webhook.go
Outdated
| @@ -79,6 +79,13 @@ func (in *JVMChaosSpec) Validate(root interface{}, path *field.Path) field.Error | |||
| if len(in.RuleData) == 0 { | |||
| allErrs = append(allErrs, field.Invalid(path, in, "rule data not provide")) | |||
| } | |||
| case JVMMySQLAction: | |||
| if len(in. MySQLConnectorVersion) == 0 { | |||
There was a problem hiding this comment.
| if len(in. MySQLConnectorVersion) == 0 { | |
| if len(in.MySQLConnectorVersion) == 0 { |
WangXiangUSTC
force-pushed
the
jvmchaos_mysql
branch
from
5edc1b7
to
c46ab87
Compare
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
WangXiangUSTC
force-pushed
the
jvmchaos_mysql
branch
from
2f494a4
to
f03b5ab
Compare
Signed-off-by: xiang <xiang13225080@163.com>
|
There is something wrong with my git tree and it's difficult to resolve, I will open another pr |
What problem does this PR solve?
close issue #2977
What's changed and how it works?
Related changes
chaos-mesh/websiteDashboard UIChecklist
CHANGELOG
CHANGELOG.mdTests
Side effects
Release note
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: