Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhysicalMachineChaos: update stress options type #3354

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Jun 13, 2022

Signed-off-by: xiang xiang13225080@163.com

What problem does this PR solve?

fix issue #3327

What's changed and how it works?

cherry pick from #3347

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.2
    • release-2.1

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: xiang <xiang13225080@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 13, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cwen0
  • iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@WangXiangUSTC WangXiangUSTC changed the title update stress option type PhysicalMachineChaos: update stress options type Jun 13, 2022
Signed-off-by: xiang <xiang13225080@163.com>
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3354 (2f67801) into release-2.2 (cc6b093) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-2.2    #3354      +/-   ##
===============================================
- Coverage        40.93%   40.90%   -0.03%     
===============================================
  Files              160      160              
  Lines            13624    13624              
===============================================
- Hits              5577     5573       -4     
- Misses            7626     7629       +3     
- Partials           421      422       +1     
Impacted Files Coverage Δ
api/v1alpha1/physical_machine_chaos_types.go 46.15% <ø> (ø)
api/v1alpha1/zz_generated.chaosmesh.go 56.65% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc6b093...2f67801. Read the comment docs.

Copy link
Member

@iguoyr iguoyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Jun 14, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2f67801

@ti-chi-bot ti-chi-bot merged commit 632412e into chaos-mesh:release-2.2 Jun 14, 2022
@WangXiangUSTC WangXiangUSTC deleted the stress_option_pick branch June 14, 2022 06:05
@YangKeao YangKeao mentioned this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants