Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync latest Chaosd and PhysicalMachineChaos #3477

Merged
merged 6 commits into from
Aug 5, 2022
Merged

Sync latest Chaosd and PhysicalMachineChaos #3477

merged 6 commits into from
Aug 5, 2022

Conversation

FingerLeader
Copy link
Member

Signed-off-by: FingerLeader wanxfinger@gmail.com

What problem does this PR solve?

Make PhysicalMachineChaos support the Chaosd(commit 41bf629270d6ae9459f112593d767334e582ce0b)

What's changed and how it works?

Update APIs and webhook

@FingerLeader
sync lates chaosd and physicalmachinechaos
bb88081 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • WangXiangUSTC
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@FingerLeader
update CHANGELOG.md
457d0e3 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
Copy link
Member Author

Most code lines are YAML file, take it easy to review ❤️

@codecov
Copy link

codecov bot commented Jul 25, 2022 •
edited
Loading

Codecov Report

Merging #3477 (89c2c7b) into master (3d299ed) will decrease coverage by 0.58%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3477      +/-   ##
==========================================
- Coverage   40.87%   40.29%   -0.59%     
==========================================
  Files         166      166              
  Lines       13973    14181     +208     
==========================================
+ Hits         5712     5714       +2     
- Misses       7830     8036     +206     
  Partials      431      431
Impacted Files Coverage Δ
api/v1alpha1/physical_machine_chaos_types.go 46.15% <ø> (ø)
api/v1alpha1/physical_machine_chaos_webhook.go 55.05% <0.00%> (-31.49%) ⬇️
pkg/chaosdaemon/jvm_server.go 0.00% <0.00%> (ø)
.../workflow/controllers/abort_workflow_reconciler.go 48.97% <0.00%> (-8.17%) ⬇️
api/v1alpha1/zz_generated.chaosmesh.go 56.58% <0.00%> (-0.78%) ⬇️
pkg/webhook/validate_auth.go 0.00% <0.00%> (ø)
.../workflow/controllers/workflow_entry_reconciler.go 56.21% <0.00%> (+2.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d83ebf...89c2c7b. Read the comment docs.

@cwen0
Copy link
Member

cwen0 commented Aug 2, 2022

@WangXiangUSTC @Andrewmatilde PTAL

@FingerLeader
add user_defined
ccd9fdc 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
update CHANGELOG.md
8e3bf9e 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
WangXiangUSTC
WangXiangUSTC approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

cwen0
cwen0 approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Aug 4, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8de9f91

@ti-chi-bot ti-chi-bot merged commit 7dd858f into chaos-mesh:master Aug 5, 2022
@FingerLeader FingerLeader mentioned this pull request Aug 9, 2022
Closed
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.3 failed

@FingerLeader FingerLeader mentioned this pull request Aug 30, 2022
Merged
11 tasks
g1eny0ung pushed a commit that referenced this pull request Aug 30, 2022
@FingerLeader
cherry-pick #3477 to release-2.3 (#3579)
668ad28 
* sync physicalmachinechaos

Signed-off-by: Ningxuan Wang <wanxfinger@gmail.com>

Signed-off-by: Ningxuan Wang <wanxfinger@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwen0 cwen0 cwen0 approved these changes

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

@Hexilee Hexilee Awaiting requested review from Hexilee

Assignees
No one assigned
Labels
chaos/physical-machine needs-cherry-pick-release-2.3 size/XXL status/can-merge status/LGT2 type/enhancement Request for an improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FingerLeader @ti-chi-bot @cwen0 @ti-srebot @WangXiangUSTC