Remove crd v1beta1 Support #3630

STRRL · 2022-09-14T02:48:49Z

What problem does this PR solve?

close #3577

What's changed and how it works?

remove manifests about CRD v1beta1
remove kubernetes 1.15 in e2e tests, append kubernetes 1.25 in e2e tests
bump the e2e test framework to 1.24, because the behavior changes about serviceaccount would break e2e tests on 1.24/1.25

Related changes

This change also requires further updates to the website (e.g. docs)
This change also requires further updates to the UI interface
Need to cheery-pick to release branches
- release-2.3
- release-2.2

Checklist

CHANGELOG

I have updated the CHANGELOG.md
I have labeled this PR with "no-need-update-changelog"

Tests

Unit test
E2E test
No code
Manual test (add steps below)

Side effects

Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

ti-chi-bot · 2022-09-14T02:48:51Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Andrewmatilde

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2022-09-14T03:05:29Z

Codecov Report

Merging #3630 (2929f3f) into master (8fd92d1) will decrease coverage by 0.09%.
The diff coverage is 1.29%.

@@            Coverage Diff             @@
##           master    #3630      +/-   ##
==========================================
- Coverage   40.24%   40.14%   -0.10%     
==========================================
  Files         166      166              
  Lines       14160    14192      +32     
==========================================
  Hits         5698     5698              
- Misses       8027     8060      +33     
+ Partials      435      434       -1

Impacted Files	Coverage Δ
api/v1alpha1/common_types.go	`0.00% <ø> (ø)`
api/v1alpha1/dnschaos_type.go	`0.00% <ø> (ø)`
api/v1alpha1/networkchaos_types.go	`0.00% <ø> (ø)`
api/v1alpha1/physical_machine_chaos_types.go	`46.15% <ø> (ø)`
api/v1alpha1/physical_machine_chaos_webhook.go	`54.47% <0.00%> (ø)`
api/v1alpha1/podchaos_types.go	`0.00% <ø> (ø)`
api/v1alpha1/schedule_types.go	`14.28% <ø> (ø)`
api/v1alpha1/statuscheck_types.go	`0.00% <ø> (ø)`
api/v1alpha1/stresschaos_types.go	`0.00% <ø> (ø)`
api/v1alpha1/timechaos_types.go	`0.00% <ø> (ø)`
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e472f7...2929f3f. Read the comment docs.

Signed-off-by: STRRL <im@strrl.dev>

remove 1.15.x, append 1.25.x Signed-off-by: STRRL <im@strrl.dev>

Signed-off-by: STRRL <im@strrl.dev>

Andrewmatilde

Plz fix the ci.

Andrewmatilde · 2022-09-18T02:52:35Z

pkg/ctrl/server/schema.resolvers.go

@@ -175,6 +174,10 @@ func (r *hTTPChaosResolver) Annotations(ctx context.Context, obj *v1alpha1.HTTPC
 	return annotations, nil
 }

+func (r *hTTPChaosResolver) ClusterName(ctx context.Context, obj *v1alpha1.HTTPChaos) (string, error) {


It is strange here. I guess it is because the kube go mod we relied on changed.
You may need to turn the type of HTTPChaos.ClusterName to string here.

I have no idea about what ClusterName is 🤔. It has been here 13 months ago.

also cc @Hexilee

metadata.clusterName is deprecated in 1.24 and removed in 1.25, since it is event not used, I would remove it from the graphql.

ref:

Remove ClusterName kubernetes/kubernetes#108717

Finish clustername removal kubernetes/kubernetes#109602

Signed-off-by: STRRL <im@strrl.dev>

the auto cni would let source IP as the 172.27.0.1, which breaks the DNSChaos Signed-off-by: STRRL <im@strrl.dev>

Signed-off-by: STRRL <im@strrl.dev>

STRRL · 2022-09-20T06:02:27Z

/cc @chaos-mesh/committers @chaos-mesh/maintainers
This PR is ready for review!

Andrewmatilde

LGTM

STRRL · 2022-09-21T12:00:25Z

/merge

ti-chi-bot · 2022-09-21T12:00:31Z

This pull request has been accepted and is ready to merge.

Commit hash: c57e3dc

ti-srebot · 2022-09-21T12:29:04Z

cherry pick to release-2.4 in PR #3662

* feat: remove support for crd-v1beta1 Signed-off-by: STRRL <im@strrl.dev> * test: skew kubernetes version in e2e test remove 1.15.x, append 1.25.x Signed-off-by: STRRL <im@strrl.dev> * chore: Update Changelog Signed-off-by: STRRL <im@strrl.dev> * chore: bump minkube version in e2e test to 1.26.1 Signed-off-by: STRRL <im@strrl.dev> * fix: use calico to replace broken flannel cni Signed-off-by: STRRL <im@strrl.dev> * fix: use cilium to instaed broken calico in e2e tests Signed-off-by: STRRL <im@strrl.dev> * ci: use default cni to bootstrap e2e test cluster Signed-off-by: STRRL <im@strrl.dev> * chore: bump dependency version to fix e2e test on 1.25 Signed-off-by: STRRL <im@strrl.dev> * chore: make check Signed-off-by: STRRL <im@strrl.dev> * feat: bump api dependency version, remove clusterName Signed-off-by: STRRL <im@strrl.dev> * chore: remove unused methods Signed-off-by: STRRL <im@strrl.dev> * fix: leader-election: use configmapsleases Signed-off-by: STRRL <im@strrl.dev> * chore: update rbac for new leader election resouce Signed-off-by: STRRL <im@strrl.dev> * chore: make check Signed-off-by: STRRL <im@strrl.dev> * chore: use calico cni to fix e2e tests the auto cni would let source IP as the 172.27.0.1, which breaks the DNSChaos Signed-off-by: STRRL <im@strrl.dev> * chore: bump minikube to 1.27.0 to use calico with k8s 1.25.1 Signed-off-by: STRRL <im@strrl.dev> * test: let e2e use priviledged level PSP Signed-off-by: STRRL <im@strrl.dev> * chore: make check Signed-off-by: STRRL <im@strrl.dev> Signed-off-by: STRRL <im@strrl.dev> Co-authored-by: STRRL <im@strrl.dev> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

Update documentation on supported releases. Version are based on chaos-mesh/chaos-mesh#3630 This PR is part of the 2.4.0 release: https://github.com/chaos-mesh/chaos-mesh/blob/release-2.4/.github/workflows/e2e_test.yml#L107 Given that the lowest version tested is 1.20 - removing anyhing below it from the supported list Signed-off-by: jekader <jekader@gmail.com> Signed-off-by: jekader <jekader@gmail.com>

ti-chi-bot requested a review from Gallardot September 14, 2022 02:49

ti-chi-bot added the size/M label Sep 14, 2022

ti-chi-bot added needs-rebase and removed needs-rebase labels Sep 14, 2022

STRRL requested review from a team September 17, 2022 23:09

STRRL added 7 commits September 18, 2022 08:19

feat: remove support for crd-v1beta1

8593367

Signed-off-by: STRRL <im@strrl.dev>

test: skew kubernetes version in e2e test

db5313e

remove 1.15.x, append 1.25.x Signed-off-by: STRRL <im@strrl.dev>

chore: Update Changelog

a8b168d

Signed-off-by: STRRL <im@strrl.dev>

chore: bump minkube version in e2e test to 1.26.1

11e9a75

Signed-off-by: STRRL <im@strrl.dev>

fix: use calico to replace broken flannel cni

3d2f41d

Signed-off-by: STRRL <im@strrl.dev>

fix: use cilium to instaed broken calico in e2e tests

d361e94

Signed-off-by: STRRL <im@strrl.dev>

ci: use default cni to bootstrap e2e test cluster

a700d13

Signed-off-by: STRRL <im@strrl.dev>

STRRL force-pushed the remove-crd-v1-beta1 branch from 1b16cd2 to a700d13 Compare September 18, 2022 00:19

ti-chi-bot added size/XXL and removed needs-rebase size/M labels Sep 18, 2022

chore: bump dependency version to fix e2e test on 1.25

b42df3e

Signed-off-by: STRRL <im@strrl.dev>

STRRL force-pushed the remove-crd-v1-beta1 branch from 84de2fb to b42df3e Compare September 18, 2022 02:28

Andrewmatilde reviewed Sep 18, 2022

View reviewed changes

STRRL added 5 commits September 19, 2022 09:54

chore: make check

d537b89

Signed-off-by: STRRL <im@strrl.dev>

feat: bump api dependency version, remove clusterName

471983e

Signed-off-by: STRRL <im@strrl.dev>

chore: remove unused methods

87519d0

Signed-off-by: STRRL <im@strrl.dev>

fix: leader-election: use configmapsleases

abec748

Signed-off-by: STRRL <im@strrl.dev>

chore: update rbac for new leader election resouce

c8c2e51

Signed-off-by: STRRL <im@strrl.dev>

STRRL force-pushed the remove-crd-v1-beta1 branch from b67a0c8 to c8c2e51 Compare September 19, 2022 07:50

STRRL added rebuild-build-env-image rebuild build-env image in this PR rebuild-dev-env-image rebuild dev-env image in this PR labels Sep 19, 2022

STRRL added 5 commits September 19, 2022 16:33

chore: make check

0343866

Signed-off-by: STRRL <im@strrl.dev>

chore: use calico cni to fix e2e tests

5e6800a

the auto cni would let source IP as the 172.27.0.1, which breaks the DNSChaos Signed-off-by: STRRL <im@strrl.dev>

chore: bump minikube to 1.27.0 to use calico with k8s 1.25.1

1292f18

Signed-off-by: STRRL <im@strrl.dev>

test: let e2e use priviledged level PSP

50a4416

Signed-off-by: STRRL <im@strrl.dev>

chore: make check

c57e3dc

Signed-off-by: STRRL <im@strrl.dev>

ti-chi-bot requested a review from a team September 20, 2022 06:02

STRRL added the need-cherry-pick-2.4 label Sep 20, 2022

STRRL requested a review from Andrewmatilde September 20, 2022 06:16

Andrewmatilde approved these changes Sep 20, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 label Sep 20, 2022

g1eny0ung added needs-cherry-pick-release-2.4 and removed need-cherry-pick-2.4 labels Sep 21, 2022

STRRL added the require-LGT1 label Sep 21, 2022

ti-chi-bot added the status/can-merge label Sep 21, 2022

Merge branch 'master' into remove-crd-v1-beta1

2929f3f

ti-chi-bot merged commit e172c06 into chaos-mesh:master Sep 21, 2022

ti-srebot mentioned this pull request Sep 21, 2022

Remove crd v1beta1 Support (#3630) #3662

Merged

11 tasks

jekader mentioned this pull request Oct 13, 2022

Update supported k8s versions chaos-mesh/website#360

Merged

STRRL mentioned this pull request Nov 21, 2022

chore: remove not required file crd-v1beta1.yaml #3807

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove crd v1beta1 Support #3630

Remove crd v1beta1 Support #3630

STRRL commented Sep 14, 2022 •

edited

Loading

ti-chi-bot commented Sep 14, 2022 •

edited

Loading

codecov bot commented Sep 14, 2022 •

edited

Loading

Andrewmatilde left a comment •

edited

Loading

Andrewmatilde Sep 18, 2022

STRRL Sep 19, 2022

STRRL Sep 19, 2022

STRRL Sep 19, 2022

STRRL commented Sep 20, 2022

Andrewmatilde left a comment

STRRL commented Sep 21, 2022

ti-chi-bot commented Sep 21, 2022

ti-srebot commented Sep 21, 2022

Remove crd v1beta1 Support #3630

Remove crd v1beta1 Support #3630

Conversation

STRRL commented Sep 14, 2022 • edited Loading

What problem does this PR solve?

What's changed and how it works?

Related changes

Checklist

DCO

ti-chi-bot commented Sep 14, 2022 • edited Loading

codecov bot commented Sep 14, 2022 • edited Loading

Codecov Report

Andrewmatilde left a comment • edited Loading

Choose a reason for hiding this comment

Andrewmatilde Sep 18, 2022

Choose a reason for hiding this comment

STRRL Sep 19, 2022

Choose a reason for hiding this comment

STRRL Sep 19, 2022

Choose a reason for hiding this comment

STRRL Sep 19, 2022

Choose a reason for hiding this comment

STRRL commented Sep 20, 2022

Andrewmatilde left a comment

Choose a reason for hiding this comment

STRRL commented Sep 21, 2022

ti-chi-bot commented Sep 21, 2022

ti-srebot commented Sep 21, 2022

STRRL commented Sep 14, 2022 •

edited

Loading

ti-chi-bot commented Sep 14, 2022 •

edited

Loading

codecov bot commented Sep 14, 2022 •

edited

Loading

Andrewmatilde left a comment •

edited

Loading