Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync PhysicalMachineChaos to API client and forms #3660

Merged
merged 3 commits into from
Sep 21, 2022

Conversation

g1eny0ung
Copy link
Member

@g1eny0ung g1eny0ung commented Sep 21, 2022

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What problem does this PR solve?

Problems from #3655.

What's changed and how it works?

Run codegen and check.

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface
  • Need to cheery-pick to release branches
    • release-2.4
    • release-2.3
    • release-2.2

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #3660 (90eb346) into master (e172c06) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3660      +/-   ##
==========================================
+ Coverage   40.08%   40.29%   +0.21%     
==========================================
  Files         166      166              
  Lines       14192    14192              
==========================================
+ Hits         5689     5719      +30     
+ Misses       8068     8043      -25     
+ Partials      435      430       -5     
Impacted Files Coverage Δ
api/v1alpha1/physical_machine_chaos_types.go 46.15% <ø> (ø)
pkg/selector/generic/mode.go 25.64% <0.00%> (-2.57%) ⬇️
pkg/workflow/controllers/task_reconciler.go 6.70% <0.00%> (+0.80%) ⬆️
pkg/workflow/controllers/statuscheck_reconciler.go 9.09% <0.00%> (+1.51%) ⬆️
pkg/workflow/controllers/serial_node_reconciler.go 61.13% <0.00%> (+1.55%) ⬆️
...g/workflow/controllers/parallel_node_reconciler.go 62.02% <0.00%> (+1.89%) ⬆️
pkg/workflow/controllers/abort_node_reconciler.go 18.60% <0.00%> (+3.48%) ⬆️
controllers/statuscheck/controller.go 84.14% <0.00%> (+4.87%) ⬆️
.../workflow/controllers/workflow_entry_reconciler.go 54.05% <0.00%> (+7.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e172c06...90eb346. Read the comment docs.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@STRRL
Copy link
Member

STRRL commented Sep 21, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d133d7c

@g1eny0ung g1eny0ung merged commit a6620f7 into chaos-mesh:master Sep 21, 2022
@g1eny0ung g1eny0ung deleted the fix/sync-PhysicalMachineChaos branch September 21, 2022 14:12
@ti-srebot
Copy link
Contributor

cherry pick to release-2.3 failed

@ti-srebot
Copy link
Contributor

cherry pick to release-2.4 in PR #3664

g1eny0ung added a commit that referenced this pull request Sep 21, 2022
* fix: sync PhysicalMachineChaos to API client and forms

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: update changelog

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
g1eny0ung added a commit to g1eny0ung/chaos-mesh that referenced this pull request Sep 21, 2022
* fix: sync PhysicalMachineChaos to API client and forms

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: update changelog

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
g1eny0ung added a commit that referenced this pull request Sep 21, 2022
* fix: sync PhysicalMachineChaos to API client and forms

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: update changelog

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants