-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stresschaos): support cgroup v2 for docker and cri-o #3698
feat(stresschaos): support cgroup v2 for docker and cri-o #3698
Conversation
Signed-off-by: STRRL <im@strrl.dev>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #3698 +/- ##
==========================================
- Coverage 40.01% 39.48% -0.53%
==========================================
Files 168 172 +4
Lines 14292 14478 +186
==========================================
- Hits 5719 5717 -2
- Misses 8134 8318 +184
- Partials 439 443 +4
Continue to review full report at Codecov.
|
I have manually tested this PR on all supported CRI: docker, contained, crio, and it just works... |
Signed-off-by: STRRL <im@strrl.dev>
please execute make check on your local machine :) |
Signed-off-by: STRRL <im@strrl.dev>
Updated, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it in my local arm64 docker and it works fine.
Signed-off-by: STRRL <im@strrl.dev>
/merge I removed the tag |
This pull request has been accepted and is ready to merge. Commit hash: 9fbc216
|
In response to a cherrypick label: new pull request created: #3799. |
In response to a cherrypick label: new pull request created: #3800. |
) * This is an automated cherry-pick of #3698 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * chore: resolve conflicts Signed-off-by: STRRL <im@strrl.dev> Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: STRRL <im@strrl.dev> Co-authored-by: Zhou Zhiqiang <im@strrl.dev>
) * This is an automated cherry-pick of #3698 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * chore: resolve conflict Signed-off-by: STRRL <im@strrl.dev> Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: STRRL <im@strrl.dev> Co-authored-by: Zhou Zhiqiang <im@strrl.dev>
Signed-off-by: STRRL im@strrl.dev
What problem does this PR solve?
close #2978
close #2069
What's changed and how it works?
Related changes
UI interface
Checklist
CHANGELOG
CHANGELOG.md
Tests
Side effects
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: