Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stresschaos): support cgroup v2 for docker and cri-o #3698

Merged
merged 9 commits into from
Nov 20, 2022

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Oct 14, 2022

Signed-off-by: STRRL im@strrl.dev

What problem does this PR solve?

close #2978
close #2069

What's changed and how it works?

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface
  • Need to cheery-pick to release branches
    • release-2.4
    • release-2.3

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: STRRL <im@strrl.dev>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • g1eny0ung

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #3698 (9fbc216) into master (fc1349d) will decrease coverage by 0.52%.
The diff coverage is 8.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3698      +/-   ##
==========================================
- Coverage   40.01%   39.48%   -0.53%     
==========================================
  Files         168      172       +4     
  Lines       14292    14478     +186     
==========================================
- Hits         5719     5717       -2     
- Misses       8134     8318     +184     
- Partials      439      443       +4     
Impacted Files Coverage Δ
...ntrollers/multicluster/remotecluster/controller.go 0.00% <0.00%> (ø)
pkg/chaosdaemon/stress_server_linux.go 0.00% <0.00%> (ø)
pkg/helm/restclientgetter.go 0.00% <0.00%> (ø)
...ontrollers/multicluster/remotecluster/condition.go 81.25% <81.25%> (ø)
controllers/statuscheck/controller.go 79.26% <0.00%> (-4.88%) ⬇️
pkg/workflow/controllers/chaos_node_reconciler.go 58.16% <0.00%> (-3.16%) ⬇️
pkg/workflow/controllers/deadline_reconciler.go 66.66% <0.00%> (ø)
controllers/multicluster/remotecluster/fx.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d62eeb4...9fbc216. Read the comment docs.

@STRRL STRRL added this to the Release 2.5 milestone Oct 18, 2022
@STRRL STRRL marked this pull request as ready for review November 7, 2022 03:11
@STRRL
Copy link
Member Author

STRRL commented Nov 7, 2022

I have manually tested this PR on all supported CRI: docker, contained, crio, and it just works...

@Andrewmatilde
Copy link
Member

please execute make check on your local machine :)

@STRRL
Copy link
Member Author

STRRL commented Nov 9, 2022

please execute make check on your local machine :)

Updated, PTAL

@g1eny0ung g1eny0ung changed the title feat: support stresschaos with cgroup v2 feat(stresschaos): support cgroup v2 for docker and cri-o Nov 19, 2022
Copy link
Member

@g1eny0ung g1eny0ung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it in my local arm64 docker and it works fine.

CHANGELOG.md Outdated Show resolved Hide resolved
@STRRL
Copy link
Member Author

STRRL commented Nov 20, 2022

/merge

I removed the tag cherry-pick-release-2.3 because we do not maintain that minor version.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9fbc216

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3799.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3800.

ti-chi-bot added a commit that referenced this pull request Nov 20, 2022
)

* This is an automated cherry-pick of #3698

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* chore: resolve conflicts

Signed-off-by: STRRL <im@strrl.dev>

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: STRRL <im@strrl.dev>
Co-authored-by: Zhou Zhiqiang <im@strrl.dev>
ti-chi-bot added a commit that referenced this pull request Nov 20, 2022
)

* This is an automated cherry-pick of #3698

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* chore: resolve conflict

Signed-off-by: STRRL <im@strrl.dev>

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: STRRL <im@strrl.dev>
Co-authored-by: Zhou Zhiqiang <im@strrl.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cgroup v2 support for docker and cri-o support cgroup v2
4 participants