bump go to 1.19.3 #3770

hypnoce · 2022-11-09T20:55:33Z

Signed-off-by: JACQUES Francois Francois.JACQUES@murex.com

What problem does this PR solve?

Update to latest go 1.19.3 for dev, test and release.

What's changed and how it works?

Related changes

This change also requires further updates to the website (e.g. docs)
This change also requires further updates to the UI interface
Need to cheery-pick to release branches
- release-2.4
- release-2.3

Checklist

CHANGELOG

I have updated the CHANGELOG.md
I have labeled this PR with "no-need-update-changelog"

Tests

Unit test
E2E test
No code
Manual test (add steps below)

Side effects

Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

ti-chi-bot · 2022-11-09T20:55:36Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

STRRL
xlgao-zju

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2022-11-09T20:55:42Z

Welcome @hypnoce!

It looks like this is your first PR to chaos-mesh/chaos-mesh 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to chaos-mesh/chaos-mesh. 😃

STRRL · 2022-11-10T04:00:30Z

please execute go mod tidy and make check and commit the changes :")

hypnoce · 2022-11-10T08:40:45Z

@STRRL done

STRRL · 2022-11-13T06:33:25Z

oops, please also setup go as 1.19 in https://github.com/chaos-mesh/chaos-mesh/blob/master/.github/workflows/codecov_unittest.yaml

Rest LGTM!

hypnoce · 2022-11-13T13:27:44Z

I cannot update any go version in https://github.com/chaos-mesh/chaos-mesh/blob/master/.github/workflows/codecov_unittest.yaml
I think this PR should have labels rebuild-build-env-image and rebuild-dev-env-image. WDYT ?

hypnoce · 2022-11-13T13:33:30Z

/label rebuild-build-env-image

ti-chi-bot · 2022-11-13T13:33:33Z

@hypnoce: The label(s) rebuild-build-env-image cannot be applied. These labels are supported: bugbash, contribution, DNM, Hacktoberfest, dependencies, documentation, duplicate, good first issue, invalid, need-more-info, needs-cherry-pick-release-0.8, needs-cherry-pick-release-0.9, needs-cherry-pick-release-1.0, needs-cherry-pick-release-1.1, needs-cherry-pick-release-1.2, needs-cherry-pick-release-2.0, needs-cherry-pick-release-2.1, needs-cherry-pick-release-2.2, needs-cherry-pick-release-2.3, needs-cherry-pick-release-2.4, needs-cherry-pick-release-2.5, require-LGT3.

In response to this:

/label rebuild-build-env-image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

STRRL · 2022-11-13T13:36:52Z

I cannot update any go version in https://github.com/chaos-mesh/chaos-mesh/blob/master/.github/workflows/codecov_unittest.yaml I think this PR should have labels rebuild-build-env-image and rebuild-dev-env-image. WDYT ?

You're right. Thanks!

But the bot does not works well, I manually append these labels.

Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>

STRRL · 2022-11-13T13:41:25Z

I just realized that GitHub Action requires a new commit to let new labels get effected, I would try to make a new commit, without any changes and forcely push to re-trigger the CI.

hypnoce · 2022-11-13T13:47:20Z

emqx.com seems unreachable 😯

hypnoce · 2022-11-13T15:09:59Z

I ran make test locally and it passed. Not sure what happened on the CI.

codecov · 2022-11-14T01:06:59Z

Codecov Report

Merging #3770 (f4a8f68) into master (191c9ae) will increase coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3770      +/-   ##
==========================================
+ Coverage   39.88%   40.13%   +0.25%     
==========================================
  Files         168      168              
  Lines       14293    14293              
==========================================
+ Hits         5701     5737      +36     
+ Misses       8149     8123      -26     
+ Partials      443      433      -10

Impacted Files	Coverage Δ
api/v1alpha1/jvmchaos_types.go	`33.33% <ø> (ø)`
controllers/action/multiplexer.go	`95.12% <ø> (ø)`
pkg/chaosdaemon/tasks/task_manager.go	`40.54% <ø> (ø)`
pkg/command/command.go	`79.66% <ø> (ø)`
pkg/workflow/controllers/task_reconciler.go	`6.70% <0.00%> (+0.80%)`	⬆️
pkg/workflow/controllers/statuscheck_reconciler.go	`9.09% <0.00%> (+1.51%)`	⬆️
pkg/workflow/controllers/serial_node_reconciler.go	`61.13% <0.00%> (+1.55%)`	⬆️
...g/workflow/controllers/parallel_node_reconciler.go	`62.02% <0.00%> (+1.89%)`	⬆️
.../workflow/controllers/workflow_entry_reconciler.go	`49.18% <0.00%> (+2.16%)`	⬆️
pkg/selector/generic/mode.go	`28.20% <0.00%> (+2.56%)`	⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191c9ae...f4a8f68. Read the comment docs.

STRRL · 2022-11-14T09:03:15Z

I ran make test locally and it passed. Not sure what happened on the CI.

I think CI failed because of the unstable networking, I have triggered the retry, and it passed now. 🥳

STRRL

LGTM

STRRL · 2022-11-14T09:03:56Z

/cc @chaos-mesh/maintainers @chaos-mesh/committers

xlgao-zju

LGTM

STRRL · 2022-11-14T09:31:21Z

/merge

Thanks for your contribution!! @hypnoce

ti-chi-bot · 2022-11-14T09:31:24Z

This pull request has been accepted and is ready to merge.

Commit hash: 415c3bb

ti-chi-bot · 2022-11-14T12:48:16Z

@hypnoce: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-03-24T01:41:06Z

In response to a cherrypick label: new pull request created to branch release-2.5: #3980.

* This is an automated cherry-pick of #3770 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * Update CHANGELOG.md Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> --------- Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: François JACQUES <hypnoce@donarproject.org> Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>

ti-chi-bot added contribution first-time-contributor labels Nov 9, 2022

ti-chi-bot requested a review from STRRL November 9, 2022 20:55

ti-chi-bot added the size/S label Nov 9, 2022

hypnoce force-pushed the bump-go1.19.3 branch from be6e1ef to cddfb43 Compare November 9, 2022 20:56

hypnoce force-pushed the bump-go1.19.3 branch from cddfb43 to 214518b Compare November 10, 2022 08:40

ti-chi-bot added size/L and removed size/S labels Nov 10, 2022

STRRL added rebuild-build-env-image rebuild build-env image in this PR rebuild-dev-env-image rebuild dev-env image in this PR labels Nov 13, 2022

bump go to 1.19.3

415c3bb

Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>

STRRL force-pushed the bump-go1.19.3 branch from 214518b to 415c3bb Compare November 13, 2022 13:41

STRRL approved these changes Nov 14, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 label Nov 14, 2022

ti-chi-bot requested a review from a team November 14, 2022 09:03

xlgao-zju approved these changes Nov 14, 2022

View reviewed changes

ti-chi-bot added status/LGT2 and removed status/LGT1 labels Nov 14, 2022

ti-chi-bot added the status/can-merge label Nov 14, 2022

ti-chi-bot added 2 commits November 14, 2022 17:31

Merge branch 'master' into bump-go1.19.3

24defbb

Merge branch 'master' into bump-go1.19.3

f4a8f68

g1eny0ung merged commit 8dc83ab into chaos-mesh:master Nov 15, 2022

cwen0 added the needs-cherry-pick-release-2.5 label Mar 24, 2023

ti-chi-bot mentioned this pull request Mar 24, 2023

bump go to 1.19.3 (#3770) #3980

Merged

11 tasks

cwen0 mentioned this pull request Mar 24, 2023

upgrade go version to 1.19.7 to fix CVE-2022-41723 (#3978) #3979

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump go to 1.19.3 #3770

bump go to 1.19.3 #3770

hypnoce commented Nov 9, 2022

ti-chi-bot commented Nov 9, 2022 •

edited

Loading

ti-chi-bot commented Nov 9, 2022

STRRL commented Nov 10, 2022

hypnoce commented Nov 10, 2022

STRRL commented Nov 13, 2022

hypnoce commented Nov 13, 2022

hypnoce commented Nov 13, 2022

ti-chi-bot commented Nov 13, 2022

STRRL commented Nov 13, 2022

STRRL commented Nov 13, 2022 •

edited

Loading

hypnoce commented Nov 13, 2022

hypnoce commented Nov 13, 2022 •

edited

Loading

codecov bot commented Nov 14, 2022 •

edited

Loading

STRRL commented Nov 14, 2022

STRRL left a comment

STRRL commented Nov 14, 2022

xlgao-zju left a comment

STRRL commented Nov 14, 2022

ti-chi-bot commented Nov 14, 2022

ti-chi-bot commented Nov 14, 2022

ti-chi-bot commented Mar 24, 2023

bump go to 1.19.3 #3770

bump go to 1.19.3 #3770

Conversation

hypnoce commented Nov 9, 2022

What problem does this PR solve?

What's changed and how it works?

Related changes

Checklist

DCO

ti-chi-bot commented Nov 9, 2022 • edited Loading

ti-chi-bot commented Nov 9, 2022

STRRL commented Nov 10, 2022

hypnoce commented Nov 10, 2022

STRRL commented Nov 13, 2022

hypnoce commented Nov 13, 2022

hypnoce commented Nov 13, 2022

ti-chi-bot commented Nov 13, 2022

STRRL commented Nov 13, 2022

STRRL commented Nov 13, 2022 • edited Loading

hypnoce commented Nov 13, 2022

hypnoce commented Nov 13, 2022 • edited Loading

codecov bot commented Nov 14, 2022 • edited Loading

Codecov Report

STRRL commented Nov 14, 2022

STRRL left a comment

Choose a reason for hiding this comment

STRRL commented Nov 14, 2022

xlgao-zju left a comment

Choose a reason for hiding this comment

STRRL commented Nov 14, 2022

ti-chi-bot commented Nov 14, 2022

ti-chi-bot commented Nov 14, 2022

ti-chi-bot commented Mar 24, 2023

ti-chi-bot commented Nov 9, 2022 •

edited

Loading

STRRL commented Nov 13, 2022 •

edited

Loading

hypnoce commented Nov 13, 2022 •

edited

Loading

codecov bot commented Nov 14, 2022 •

edited

Loading