-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui): use pnpm package manager #3965
Conversation
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3965 +/- ##
==========================================
- Coverage 38.60% 38.52% -0.09%
==========================================
Files 165 165
Lines 13698 13698
==========================================
- Hits 5288 5277 -11
- Misses 7979 7991 +12
+ Partials 431 430 -1
Continue to review full report at Codecov.
|
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
* install offline Helm Chart for multi cluster Signed-off-by: nio <nioshield@gmail.com> * fix remotecluster current version Signed-off-by: nio <nioshield@gmail.com> * chore: bump ginkgo version in dev-env to v2 (#3923) Signed-off-by: STRRL <im@strrl.dev> Signed-off-by: nio <nioshield@gmail.com> * Update install.sh to work on macos (#3901) * Update install.sh to work on macos The default bash version on MacOS does not support reading an array directly from a variable. Instead, use `read -a` to accomplish separating version numbers. Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com> * chore: update changelog Signed-off-by: STRRL <im@strrl.dev> --------- Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com> Signed-off-by: STRRL <im@strrl.dev> Co-authored-by: STRRL <im@strrl.dev> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: nio <nioshield@gmail.com> * update chaos-coredns version to v0.2.4 (#3947) * update chaos-coredns version to v0.2.4 Signed-off-by: Xianglin Gao <xianglingao@tencent.com> * update chaos-coredns version to v0.2.4 Signed-off-by: Xianglin Gao <xianglingao@tencent.com> --------- Signed-off-by: Xianglin Gao <xianglingao@tencent.com> Signed-off-by: nio <nioshield@gmail.com> * Revert "update chaos-coredns version to v0.2.4" (#3967) This reverts commit b031d88. Signed-off-by: nio <nioshield@gmail.com> * refactor(ui): use pnpm package manager (#3965) * chore: init Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * test: add jest-dom types Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: add @mui/base Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: types Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: clear yarn usage Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update changelog Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: update storyshots Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: downgrade react-testing-library Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: @ui/app tests Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: unknown unsafe-perm Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> --------- Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Signed-off-by: nio <nioshield@gmail.com> * upgrade dns coredns image url to ghcr.io (#3488) * upgrade dns coredns image url to ghcr.io Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add CHANGELOG Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * replace pingcap project with chaos-mesh Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add back docker-push-dns-server Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * chore: bump the version of chaos-coredns to v0.2.2 Signed-off-by: STRRL <im@strrl.dev> * update Makefile Signed-off-by: Cwen Yin <cwenyin0@gmail.com> * chore: bump coredns image version to 0.2.4 Signed-off-by: STRRL <im@strrl.dev> * test: use latest image Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: follow sonatype-lift suggestions Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update chaos-coredns to v0.2.5 Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: changelog Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: typo Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: update dnsServer.image Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: remove pingcap Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: typo Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: add ghcr.io registry Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * Rename ChaosDNSImage to ChaosCoreDNSImage Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * feat: bump chaos-coredns version to v0.2.6, and enable dnsServer.create as default Signed-off-by: STRRL <im@strrl.dev> * chore: update the helm chart configs Signed-off-by: STRRL <im@strrl.dev> * chore: make check Signed-off-by: STRRL <im@strrl.dev> --------- Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Signed-off-by: STRRL <im@strrl.dev> Signed-off-by: Cwen Yin <cwenyin0@gmail.com> Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: STRRL <im@strrl.dev> Co-authored-by: Cwen Yin <cwenyin0@gmail.com> Co-authored-by: Yue Yang <g1enyy0ung@gmail.com> Signed-off-by: nio <nioshield@gmail.com> * fix: supplement read-only token (#3971) Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Signed-off-by: nio <nioshield@gmail.com> * fix: migrate from k8s.gcr.io to registry.k8s.io (#3974) Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> Signed-off-by: nio <nioshield@gmail.com> * Update pkg/helm/chart.go Co-authored-by: Zhou Zhiqiang <im@strrl.dev> Signed-off-by: nio <nioshield@gmail.com> --------- Signed-off-by: nio <nioshield@gmail.com> Signed-off-by: STRRL <im@strrl.dev> Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com> Signed-off-by: Xianglin Gao <xianglingao@tencent.com> Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Signed-off-by: Cwen Yin <cwenyin0@gmail.com> Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> Co-authored-by: Zhou Zhiqiang <im@strrl.dev> Co-authored-by: Blaine Gardner <b.blaine.gardner@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: Xianglin Gao <xianglingao@tencent.com> Co-authored-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Cwen Yin <cwenyin0@gmail.com> Co-authored-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
What's changed and how it works?
In this PR, I change the package manager from
yarn
topnpm
.The old
yarn
classic (v1) has some usage bugs (like this: yarnpkg/yarn#7807) that disturb daily development work. But it is no longer updated anymore.So for long-term considerations, the
pnpm
is a good replacement choice. It's fast and disk space efficient, I've used it in several projects and it works fine with monorepo. It has been tested by time!Related changes
UI interface
Checklist
CHANGELOG
CHANGELOG.md
Tests
Side effects
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: