slurm: add -C to restrict hostlist to nodes with specified features #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restrict existing hostlist to nodes with one of the given features (like srun -C)
|
Neat! I was going to suggest adding a test to |
|
I added one silly option for a test. It should be possible to collect features with |
|
That test works for me as a sanity check, no need to go any further at this time. |
|
Looks good to me! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like
srun -C, this takes the produced hostlist and filters it to only SLURM nodes that have one of the specified features. This is useful for us in combination with-P, but certainly open to other ideas. One could imagine other slurm node filters as well, of course. Does not accept the full slurm constraint syntax ofA&B|Cstuff, just a comma list that's essentially OR-d.