dshbak: fix handling of empty input lines #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The dshbak tests do not test for empty input to the script, so a regression that broke the script on empty lines/input was able to get past make check. Add a test to ensure that empty input works with dshbak.
Problem: The fix for hostnames of `0` in dshbak, i.e. the following commit commit dee6adf Author: Mark A. Grondona <mgrondona@llnl.gov> Date: Thu Jun 25 13:37:51 2015 -0700 dshbak: Handle hostname of "0" @garlick found that dshbak can't handle the smallest of numbers. This is because dshbak skips lines where $tag resolves to false. But in perl, 0 is also false. What we really want to check for is an "empty" tag, so fix up the test to reflect that. Resolves chaos#70. breaks handling of empty input to dshbak, since now the variable "$tag" can be used when it is uninitialized. The proper fix for issue chaos#70 was to check if the variable was either uninitialized or an empty string. Fixes chaos#132
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=======================================
Coverage 63.81% 63.81%
=======================================
Files 27 27
Lines 5585 5585
=======================================
Hits 3564 3564
Misses 2021 2021 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #132 by @negregg, the fix for #70 inadvertently broke empty input in
dshbak.This PR adds a test to
t5000-dshbak.shto ensure empty input is handled by the script and then fixes the original fix.