ci: fix mergify config and prevent spurious test failures #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Mergify.io has deprecated the strict merge mode action: https://blog.mergify.io/strict-mode-deprecation/ Replace the strict mode configuration with a default queue with a rebase action which should be equivalent.
Problem: The "pretend known breakage" and "fixed known breakage" tests will fail if the test emits anything on stderr. This might cause unnecessary test failures if some debug is emitted on pdsh stderr. Remove the test for empty stderr for these tests.
garlick
approved these changes
Jun 10, 2022
|
Yes, please (b/c mergify config was modified). Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple potential CI issues: