sshcmd: fix sshcmd_signal on macos #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: On Darwin 20.6.0 hosts, sshcmd_signal() fails due to the err() call which prints "sending SIGTERM to ssh" for an unkown reason. However, this output is redundant with a similar log message printed from pipecmd_signal(), so the message is probably useless. Remove the problematic statement from sshcmd_signal().
grondo
added
the
merge-when-passing
|
Thanks! Setting MWP |
|
@Mergifyio refresh |
✅ Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is required to fix a testing issue with macos in PR #144
Problem: On Darwin 20.6.0 hosts, sshcmd_signal() fails due to
the err() call which prints "sending SIGTERM to ssh" for an unkown
reason. However, this output is redundant with a similar log message
printed from pipecmd_signal(), so the message is probably useless.
Remove the problematic statement from sshcmd_signal().