Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scorecard Patch #2935

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Scorecard Patch #2935

merged 1 commit into from
Oct 15, 2024

Conversation

IsaacMilarky
Copy link
Contributor

Description

  • Patch scorecard task to use correct flag
  • Use .get instead of index access to dictionary
  • Fix syntax error in MetadataException

This PR fixes #2927

Signed commits

  • Yes, I signed my commits.

@IsaacMilarky
fix scorecard flag from repo to local as well as syntax in metadata e…
c1036aa 
…xception

Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
sgoggins
sgoggins approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@sgoggins sgoggins merged commit efda1bd into main Oct 15, 2024
7 of 9 checks passed
@IsaacMilarky IsaacMilarky deleted the patch-ossf-scorecard-main branch October 15, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoggins sgoggins sgoggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenSSF Scorecard Patch Needs
2 participants
@IsaacMilarky @sgoggins