Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: Bug fixes in Repo Info Worker & Metric implementations #320

Merged
merged 11 commits into from
Jul 6, 2019
Merged

dev: Bug fixes in Repo Info Worker & Metric implementations #320

merged 11 commits into from
Jul 6, 2019
+584 −54

Conversation

parthsharma2
Copy link
Member

@parthsharma2 parthsharma2 commented Jul 4, 2019 •
edited
Loading

  • Fixed a few unit tests
  • Fixed a few data collection bugs in Repo Info Worker
  • Added the following metrics:
    • Forks: Returns a time series of forks
    • Fork Count: Returns the latest fork count

Update:

  • Added test for 'get_repos_for_dosocs' endpoint
  • Added the following metrics:
    • Stars: Returns a time series of stars
    • Stars Count: Returns the latest stars count
    • Watchers: Returns a time series of watchers
    • Watchers Count: Returns a time series of watchers count

@parthsharma2
update augur_db tests
fbf56e4 
Signed-off-by: Parth Sharma <parth261297@gmail.com>
@parthsharma2
fix key errors in gh_repo_info_worker
dd5227f 
Signed-off-by: Parth Sharma <parth261297@gmail.com>
@parthsharma2
add 'forks' metric implementation
d3f5e46 
Signed-off-by: Parth Sharma <parth261297@gmail.com>
@parthsharma2
add 'fork_count' metric implementation
6adb9f9 
Signed-off-by: Parth Sharma <parth261297@gmail.com>
@sgoggins sgoggins requested a review from gabe-heim July 4, 2019 19:42
@sgoggins
Copy link
Member

sgoggins commented Jul 4, 2019

The API additions and test fine tuning all look good to me. I want @gabe-heim to take a look at the worker before I merge this, must because he has a much deeper understanding of that archticture. ILGTM. ... but lets double check.

@parthsharma2
rename 'concat' in 'get_repos_for_dosocs' to 'path'
45ee33b 
Signed-off-by: Parth Sharma <parth261297@gmail.com>
@parthsharma2
add function test for 'get_repos_for_dosocs'
dd14f1c 
Signed-off-by: Parth Sharma <parth261297@gmail.com>
@parthsharma2
Copy link
Member Author

I'm adding a few metrics to this PR:

  • Stargazers
  • Watchers

@parthsharma2
add 'stars' metric implementation
c173349 
Signed-off-by: Parth Sharma <parth261297@gmail.com>
@parthsharma2
add 'stars-count' metric implementation
07db374 
Signed-off-by: Parth Sharma <parth261297@gmail.com>
@parthsharma2
add 'watchers' metric implementation
3db1f1f 
Signed-off-by: Parth Sharma <parth261297@gmail.com>
@parthsharma2
add 'watchers-count' metric implementation
4c11afd 
Signed-off-by: Parth Sharma <parth261297@gmail.com>
@parthsharma2
Merge branch 'dev' of github.com:chaoss/augur into dev
933a86f
@gabe-heim
Copy link
Contributor

All looks good to me

@gabe-heim gabe-heim merged commit dddef61 into chaoss:dev Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-heim gabe-heim Awaiting requested review from gabe-heim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthsharma2 @sgoggins @gabe-heim