Fix gh_repo_info_worker #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parth Sharma <parth261297@gmail.com>
sgoggins
reviewed
Jul 13, 2019
There was a problem hiding this comment.
@parthsharma2 : Could you add a "README.md to the worker directory that explains how to run the worker, what the log looks like when its running correctly, and whether or not we can expect the broker to figure out what to do with it automatically? Also, include the section that's required for this worker in the augur.config.json in the readme using markdown (triple code ticks ) <carriage return> ... json code <carriage return> (triple code ticks) format.
sgoggins
requested changes
Jul 13, 2019
Signed-off-by: Parth Sharma <parth261297@gmail.com>
|
@sgoggins updated the readme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the gh_repo_info_worker to fetch tasks from its maintain queue & also send task completion confirmation to the broker allowing the broker to send more tasks to this worker.
This worker can now be set to run periodically by specifying a housekeeper job in
augur.config.jsonSigned-off-by: Parth Sharma parth261297@gmail.com