Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[git] Assign stats for files with whitespaces #852

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

sduenas
Copy link
Member

@sduenas sduenas commented Nov 20, 2024

Git commit stats weren't assigned to the action for those files with whitespaces in their filenames.
Actions didn't have stats and empty stats entries were created, like in a merge commit.

The problem was that the regular expression used to parse the stats considered whitespaces as separators.

@sduenas sduenas requested a review from jjmerchante November 20, 2024 17:03
Git commit stats weren't assigned to the action
for those files with whitespaces in their filenames.
Actions didn't have stats and empty stats entries
were created, like in a merge commit.

The problem was that the regular expression used to
parse the stats considered whitespaces as separators.

Signed-off-by: Santiago Dueñas <sduenas@bitergia.com>
@sduenas sduenas force-pushed the fix-stats-pattern-git branch from 409ce7a to fa3d0a6 Compare November 20, 2024 17:04
Copy link
Contributor

@jjmerchante jjmerchante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjmerchante jjmerchante merged commit f16b29d into chaoss:master Dec 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants