Skip to content

Commit

Permalink
Reorder notifications in nightly email to better reflect priority (#2…
Browse files Browse the repository at this point in the history
…6682)

Closes Cray/chapel-private#7111.

This PR moves the errors to Brad's desired order and merges the "errors"
and "errors in bash commands" (etc.) sections.

Reviewed by @arezaii -- thanks!
  • Loading branch information
DanilaFe authored Feb 10, 2025
2 parents 0dfb840 + 968b80c commit 841a8d7
Showing 1 changed file with 7 additions and 15 deletions.
22 changes: 7 additions & 15 deletions util/cron/nightlysubs.pm
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,17 @@ sub writeEmail {
print $SF endMailHeader();
print $SF "--- New Errors -------------------------------\n";
print $SF `LC_ALL=C comm -13 $prevsummary $sortedsummary | grep -v "^.Summary:" | grep -v "$futuremarker" | grep -v "$suppressmarker"`;
print $SF `LC_ALL=C comm -13 $prevmysystemlog $sortedmysystemlog`;
print $SF "\n";

print $SF "--- Resolved Errors --------------------------\n";
print $SF `LC_ALL=C comm -23 $prevsummary $sortedsummary | grep -v "^.Summary:" | grep -v "$futuremarker" | grep -v "$suppressmarker"`;
print $SF `LC_ALL=C comm -23 $prevmysystemlog $sortedmysystemlog`;
print $SF "\n";

print $SF "--- Unresolved Errors ------------------------\n";
print $SF `LC_ALL=C comm -12 $prevsummary $sortedsummary | grep -v "^.Summary:" | grep -v "$futuremarker" | grep -v "$suppressmarker"`;
print $SF `LC_ALL=C comm -12 $prevmysystemlog $sortedmysystemlog`;
print $SF "\n";

print $SF "--- New Passing Future tests------------------\n";
Expand All @@ -189,25 +196,10 @@ sub writeEmail {
print $SF `LC_ALL=C comm -12 $prevsummary $sortedsummary | grep -v "^.Summary:" | grep "$suppressmarker" | grep "\\[Success"`;
print $SF "\n";

print $SF "--- Unresolved Errors ------------------------\n";
print $SF `LC_ALL=C comm -12 $prevsummary $sortedsummary | grep -v "^.Summary:" | grep -v "$futuremarker" | grep -v "$suppressmarker"`;
print $SF "\n";

print $SF "--- New Failing Future tests -----------------\n";
print $SF `LC_ALL=C comm -13 $prevsummary $sortedsummary | grep -v "^.Summary:" | grep "$futuremarker" | grep "\\[Error"`;
print $SF "\n";

print $SF "--- New Errors in Bash Commands ------------------\n";
print $SF `LC_ALL=C comm -13 $prevmysystemlog $sortedmysystemlog`;
print $SF "\n";

print $SF "--- Unresolved Errors in Bash Commands ------------------\n";
print $SF `LC_ALL=C comm -12 $prevmysystemlog $sortedmysystemlog`;
print $SF "\n";

print $SF "--- Resolved Errors in Bash Commands ------------------\n";
print $SF `LC_ALL=C comm -23 $prevmysystemlog $sortedmysystemlog`;
print $SF "\n";
print $SF;
print $SF endMailChplenv();
close($SF);
Expand Down

0 comments on commit 841a8d7

Please sign in to comment.