Oops, I had promotion case wrong in this test... #13040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was using A rather than AS and getting away with it due to the longstanding "forall doesn't check size matches" bug.
|
@ronawho, not sure if I should give you a second chance after all the mistakes I snuck past you yesterday :) , but can you give this a quick look? |
ronawho
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was accidentally using A rather than AS as intended and getting away with it due to the
longstanding "forall doesn't check size matches" bug (#11428). This resulted in a ridiculous
amount of communication which didn't trigger as a problem as loudly as it should've for me
yesterday.
TODO: