Fix futures for tuples of classes, add future for param folding of if expression #15541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ben-albrecht
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
Nice catch @dlongnecke-cray ! Changes LGTM.
Would you mind filing an issue for the param folding bug (assuming one doesn't exist) to go along with your future?
|
Sure thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several futures filed for #15394 failed due to incorrect folding of a param if expression which resulted in a compiler error. This PR adjusts the tests filed by #15394 to sidestep the if expression by making use of a function overload with a
whereclause. All tests intest/types/tuple/typesnow pass.