Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't remove from map while iterating over it #15957

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Don't remove from map while iterating over it #15957

merged 1 commit into from
Jun 26, 2020

Conversation

ronawho
Copy link
Contributor

@ronawho ronawho commented Jun 26, 2020

You can't remove from a map while iterating over. Update the -= and
&= map implementations to avoid that.

@ronawho
Don't remove from map while iterating over it
150e6d9 
You can't remove from a map while iterating over. Update the `-=` and
`&=` map implementations to avoid that.
@ronawho ronawho requested a review from daviditen June 26, 2020 18:45
@ronawho
Copy link
Contributor Author

ronawho commented Jun 26, 2020

@daviditen I ran into this while making some hash table optimizations. For now I just went with the simple fix for &= but I opened https://github.com/Cray/chapel-private/issues/1097 for potential optimizations.

daviditen
daviditen approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@daviditen daviditen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ronawho ronawho merged commit 693d151 into chapel-lang:master Jun 26, 2020
@ronawho ronawho deleted the fix-map-rm-while-iter branch June 26, 2020 20:42
@ronawho ronawho mentioned this pull request Jun 29, 2020
Merged
ronawho added a commit that referenced this pull request Jun 29, 2020
@ronawho
Merge pull request #15966 from ronawho/fix-assoc-arr-rm-while-iter
16b9655 
Fix associative domain ^= to avoid removing while iterating

[reviewed by @mppf]

Fix a bug in the associative domain ^= implementation where we were
removing elements while iterating over it. Similar to #15957 and #15962
@ronawho ronawho mentioned this pull request Oct 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviditen daviditen daviditen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronawho @daviditen