Mark 'Map.these' and 'Map.items' as unstable #21585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmcdonald3
changed the title
Map.these to yield key-value pairs instead of just valuesMap.these to yield key-value pairs instead of just keys
bmcdonald3
force-pushed
the
map-these
branch
from
ed06620 to
7bad5d8
Compare
bmcdonald3
changed the title
Map.these to yield key-value pairs instead of just keys
|
Marking as draft until #21654 is merged and the unstable test can be put in the directory added by that PR. |
What we would like both `Map.these()` and `Map.items()` to yield would be tuples of `(key, value)` pairs with return intent of `(const ref, ref)`, but, since that is not possible today, we are marking them both as unstable until the ability to return with the correct intent is enabled in Chapel. Signed-off-by: Ben McDonald <46734217+bmcdonald3@users.noreply.github.com>
bmcdonald3
force-pushed
the
map-these
branch
from
4d9763d to
07a7223
Compare
bmcdonald3
force-pushed
the
map-these
branch
from
07a7223 to
16f098c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #14718, what we would like both
Map.these()andMap.items()to yield would be tuples of(key, value)pairswith return intent of
(const ref, ref), but, since that is notpossible today, we are marking them both as unstable until the
ability to return with the correct intent is enabled in Chapel.