Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests to resolve previous bugs #22100

Merged
merged 5 commits into from
Apr 27, 2023

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Apr 17, 2023

Adds several new tests that are related to previous issues/bugs which were filed and are no longer broken on main.

New Tests

Testing

  • local testing

[Reviewed by @lydia-duncan ]

closes #14713
closes #12973
closes #11421
closes #11424
closes #13201
closes #5544
closes #14370

@jabraham17 jabraham17 force-pushed the tests-to-close-issues branch from a46465b to e20f5b9 Compare April 17, 2023 15:34
@jabraham17 jabraham17 marked this pull request as draft April 24, 2023 21:41
@lydia-duncan lydia-duncan self-requested a review April 27, 2023 20:36
Copy link
Member

@lydia-duncan lydia-duncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking these down! There's a typo in the PR message about classes/jade/shared-in-map-lis.chpl, looks like you're missing a t at the end there.

I've also pointed out some alternate sorting for where these tests could go, but you don't have to follow it :)

@jabraham17 jabraham17 marked this pull request as ready for review April 27, 2023 21:00
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
@jabraham17 jabraham17 force-pushed the tests-to-close-issues branch from 3dc3ad7 to d995d74 Compare April 27, 2023 21:08
@jabraham17 jabraham17 merged commit 18b5965 into chapel-lang:main Apr 27, 2023
@jabraham17 jabraham17 deleted the tests-to-close-issues branch April 27, 2023 21:31
@jabraham17 jabraham17 restored the tests-to-close-issues branch August 23, 2023 16:05
@jabraham17 jabraham17 deleted the tests-to-close-issues branch April 1, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment