-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests to resolve previous bugs #22100
Merged
jabraham17
merged 5 commits into
chapel-lang:main
from
jabraham17:tests-to-close-issues
Apr 27, 2023
Merged
Tests to resolve previous bugs #22100
jabraham17
merged 5 commits into
chapel-lang:main
from
jabraham17:tests-to-close-issues
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a46465b
to
e20f5b9
Compare
lydia-duncan
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tracking these down! There's a typo in the PR message about classes/jade/shared-in-map-lis.chpl
, looks like you're missing a t
at the end there.
I've also pointed out some alternate sorting for where these tests could go, but you don't have to follow it :)
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
3dc3ad7
to
d995d74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds several new tests that are related to previous issues/bugs which were filed and are no longer broken on main.
New Tests
classes/delete-free/shared/shared-in-map-list.chpl
- Test for Adding entries to map of shared type results in an error #14713classes/deinitializers/owned-with-deinit.chpl
- Test forproc deinit
causes compile error "unable to resolve type" #12973classes/fields/type-resolve-array-field.chpl
- Test for Unable to resolve type for array field in owned class (specific case) #11421arrays/intents/in/defaultValueWithInIntent.chpl
- Test for Default argument value for arrays asserts size for in intent #11424classes/errors/newWithoutParen.chpl
- Test for Morenil
objects returned fromnew
due to missing parentheses #13201functions/lambda/lambdaCapturing.chpl
- Test for Internal compiler error using lambdas #5544library/standard/Map/getBorrowFromFunc.chpl
- Test for Trouble returning access of map #14370Testing
[Reviewed by @lydia-duncan ]
closes #14713
closes #12973
closes #11421
closes #11424
closes #13201
closes #5544
closes #14370