-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gush dependencies #107
Conversation
I see that there is a failure in the actions running due to a NoMethodError on 'assert'. I think your adding of
I haven't been able to reproduce this locally yet though so I am not 100% sure on this as a fix in the GitHub run. Also, looks like the actions for testing are raising a deprecation about Node 16, I think this means a need for change of the |
The fact that I can't seem to easily reproduce the action test failure locally makes me think it could be something to do with the container environment in the action. Might be worth trying out adding a before hook to reset the test adapter, as I have seen some suggestions that container environments with multiple containers can have some edge with ActiveJob assertions (I have never seen it myself before though). That would mean something like I'm going to keep plugging at trying to reproduce locally, but wanted to post some thoughts in case I can help. Thanks for opening this PR btw :) |
Hi @natemontgomery! I was able to debug this locally by running |
Yea I was able to reproduce locally once I found the versions issues (and after running through the GitHub action locally). It seems like you have it well in hand, thanks again! |
Looks good but I think we should make it a 3.0.0 version |
This PR introduces following changes: