Persist dependencies so that Workflow#configure is not required on load
#118
Conversation
|
Looks good! The only nitpick I have is about the name |
Thanks! Since kwargs to this method are also used by the library user to pass in workflow data it seems important to avoid any param name that they could reasonably choose. |
…load Previously, `Workflow#configure` was called every time a Workflow was instantiated. This could create broken dependency graphs, e.g. if a configure method sets up job dependencies based on some mutable data like a timestamp argument or a database value. Instead, serialize workflow dependencies along with the rest of a workflow's data and reload it via `Client#workflow_from_hash` and tell `Workflow#initialize` not to run setup/configure. Note that for backwards compatibility with workflows persisted before this change, the setup method will still be called if dependencies in the deserialized hash are nil.
noahfpf
force-pushed
the
persist-workflow-dependencies
branch
from
49df552 to
c96287f
Compare
|
Merged! Thank you ❤️ I'm thinking with all the recent additions we could make a 3.0 version |
Thanks for merging this in! I agree a 3.0 release makes sense, though hoping to get your eyes on a few other PRs first. Let me know if you'd like a hand writing up the changelog when the time comes. |
Previously,
Workflow#configurewas called every time a Workflow was instantiated. This could create broken dependency graphs, e.g. if a configure method sets up job dependencies based on some mutable data like a timestamp argument or a database value.Instead, serialize workflow dependencies along with the rest of a workflow's data and reload it via
Client#workflow_from_hashand tellWorkflow#initializenot to run setup/configure.Note that for backwards compatibility with workflows persisted before this change, the setup method will still be called if dependencies in the deserialized hash are nil.