Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .nvmrc to use "v16" #555

Closed
JohnAlbin opened this issue Oct 17, 2023 · 0 comments · Fixed by #557
Closed

Update .nvmrc to use "v16" #555

JohnAlbin opened this issue Oct 17, 2023 · 0 comments · Fixed by #557
Labels
bug Something isn't working

Comments

@JohnAlbin
Copy link
Collaborator

JohnAlbin commented Oct 17, 2023

Package containing the bug

Not package-specific

Describe the bug

Before we deprecate Node.js v16 with the 2.0.0 release (#530), we should update the .nvmrc file which is currently pinned at v16.19.0.

The latest release of Node.js 16 was v16.20.2 and there's no reason to pin a developer's Node.js at v16.19.0.

Expected behavior

Running nvm use inside our repo, should use whatever version of Node.js v16 the developer has (or ask them to install the latest version.) That command should not force the developer to download and install a slightly-out-of-date version of Node.

Steps to reproduce:

  1. Go to the root of the repo
  2. Run nvm use
@JohnAlbin JohnAlbin added the bug Something isn't working label Oct 17, 2023
JohnAlbin added a commit that referenced this issue Oct 17, 2023
JohnAlbin added a commit that referenced this issue Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant