Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate software build on npm publish #567

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

JohnAlbin
Copy link
Collaborator

This pull request is for:

  • packages/next-drupal

GitHub Issue: #566

Describe your changes

Removes the "prepbulishOnly" lifecycle hook as it literally duplicates the running of the "prepare" hook that is already run when the software is published.

This reverts commit 1f71191.

Fixes #566

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-drupal ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2023 3:18pm

@JohnAlbin JohnAlbin force-pushed the 566-prevent-dupe-build branch from 7b5e242 to 4a3f6f8 Compare October 22, 2023 15:18
@JohnAlbin JohnAlbin requested a review from robdecker October 24, 2023 08:04
Copy link
Member

@robdecker robdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JohnAlbin JohnAlbin merged commit 2598b56 into main Oct 26, 2023
13 checks passed
@JohnAlbin JohnAlbin deleted the 566-prevent-dupe-build branch October 26, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prevent duplicate software build on npm publish
2 participants