Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure __internals to shave bytes; add react tests #82

Merged
merged 12 commits into from
Apr 22, 2023

Conversation

charkour
Copy link
Owner

@charkour charkour commented Apr 16, 2023

This is not considered a breaking change because it relied on undocumented internal APIs that were potentially accessed in userland.

937 B --> 898 B (Saves 39 bytes)
898 B --> 871 B (Saves 27 bytes) should also improve the speed because we aren't creating new arrays (less GC)
871 B --> 862 B (Saves 9 bytes) should also improve the speed because we aren't creating new arrays (less GC)
898 B --> 880 B (saves 18 bytes) add back copying arrays to make sure reactivity stays in place
880 --> 873 B (saves 7 bytes) remove object destructuring in __handleUserSet
873 B --> 870 B (saves 3 bytes) don't spread options from user
870 B --> 868 B (saves 2 bytes) don't destructure

@charkour
Copy link
Owner Author

This has a bug that react won't update because the array refs won't change

@charkour charkour changed the title restructure __internals to shave bytes restructure __internals to shave bytes; add react tests Apr 22, 2023
@charkour charkour merged commit 2145dfe into main Apr 22, 2023
@charkour charkour deleted the shave-internals branch April 22, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant