Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require connection to pypi #17

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

sbourkeostk
Copy link

Allow offline use.

Currently the program requires a http request to pypi to check for newer versions. In the case where that connection is not possible Eg. no network, firewall, etc., backup-warden cannot be used.

This PR does two things:

  1. Adds an option to disable the update check
  2. Handles the exception when the request fails and log a warning

@charles-001
Copy link
Owner

Hi @sbourkeostk - nice catch! Thank you for your contribution

@charles-001 charles-001 merged commit 1a46ca4 into charles-001:main Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants