Two other instances where a set subtraction operation would be faster as a filter #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, and as long as you ran the factored tests and they pass I'm fine. But where are you getting these performance benchmarks? |
mreposa
added a commit
that referenced
this pull request
May 8, 2015
Two other instances where a set subtraction operation would be faster as a filter
|
Good question! I'm using ScalaMeter benchmark tests, which I haven't been including in these commits. Mike mentioned that you and Glenn had been thinking about how to do performance/speed tests outside of your unit testing framework. ScalaMeter is an option but I didn't want to just start checking them in because they'd be automatically run as part of the existing sbt Test suite, which is probably not what we want. We should discuss at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of all the other uses of the set subtraction operator, these are two where the set being subtracted is generally larger. Both of these improve benchmark run times, especially the FactoredAlgorithm case.