-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created basic pyproject.toml #10
Conversation
@charlesll would it be possible to release a new version of the package to |
Yes, will do that in the upcoming days! |
Wonderful! Much appreciated 🙌 |
Hi @pawel-biernacki-roche , I am actually looking at switching to a full pyproject.toml file, but this creates issues with compilation of the FORTRAN code... It is apparently not possible to do the same things that I did in my setup.py file, if I understood right. This issue already exists when working with your minimal pyproject.toml file. Pyproject does not allow handling the Fortran compilation and extension as setup.py does. Any idea how to solve this issue ? |
Hi @charlesll , I have investigated this a bit and it seems to me that you won't be able to fully drop the
However, I personally would still recommend to move as much as possible to In case you want to go |
Hi @charlesll ! Is there any progress on pushing the new package to pypi? It starts to become a blocker for our work... Is there maybe something we could help out with? |
Hi @pawel-biernacki-roche unfortunately I did not make any progress on this side because when I include the pyproject.toml, the compilation of the FORTRAN code does not work anymore when doing pip install gcvspline. Right now I haven't found a solution (see comments above) or maybe I missed something? |
I confirm the following error when trying to install with your pyproject.toml;
I don't get why I have this error... |
@charlesll I have worked a bit more on the We have, however, encountered issues when installing the project with python 3.8, so will investigate that more. In the meantime, shall I open a PR for the |
Yes, please open a PR and I will also test it on my side. |
Created a very basic
pyproject.toml
, so that it is possible to install the package with e.g.poetry
.Previously, the following error was raised: