Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precision padding for float specifiers #274

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

Okarss
Copy link
Contributor

@Okarss Okarss commented Aug 31, 2024

Fixes the float formatting issue discovered by @josesimoes in #273.
Example of failing code:

npf_snprintf(..., ..., "%.5g", (double)INFINITY);

Output: 00inf

@charlesnicholson
Copy link
Owner

@Okarss happy to merge this when you mark it as ready for review :)

josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Sep 16, 2024
@charlesnicholson
Copy link
Owner

Ping on this @Okarss - I'm happy to merge this if you want to mark it as ready for review! :)

@charlesnicholson charlesnicholson marked this pull request as ready for review October 26, 2024 15:23
@charlesnicholson charlesnicholson merged commit 5017d7b into charlesnicholson:main Oct 26, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants