Dated subdirectories #413
Merged
Dated subdirectories #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When output files collected with split_on_transmission are being collected for a long time the output directories become inconvenient to navigate. They can have a huge amount of individual .mp3 files. This patch adds a configuration option that will put files in dated subdirectories. For example, the file: output_dir/prefix_20230831_204504.mp3 with the dated_subdirectories option will be saved like so: output_dir/2023/08/31/prefix_20230831_204504.mp3 Proposed wiki addition: * `dated_subdirectories` (boolean, optional) - when enabled will create daily subdirectories under the specified directory. The directories follow the pattern directory/YYYY/MM/DD. The default is false.
Closing a memory leak from previous commit.
- pull file / directory methods into new helper_functions.cpp/h - add unit tests for helper_functions
Closed
marcin-osowski
approved these changes
Sep 17, 2023
|
Left a few comments. Looks good! |
not seeing any new comments . . . . |
marcin-osowski
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marcin-osowski can you take a look? This is basically the same as your #407 except I took the opportunity to convert
char *tostringand moved to a new source file so unit tests can be added