Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat+fix: bracketed paste in textinput + textarea, avoid ctl chars in clipboard input #214

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

knz
Copy link
Contributor

@knz knz commented Aug 14, 2022

@knz
Copy link
Contributor Author

knz commented Aug 19, 2022

Need to wait until the other two PRs are merged before we can do CI on this one.

@knz knz changed the title Support bracketed paste in textarea Support bracketed paste in textinput + \ textarea Aug 19, 2022
@knz knz changed the title Support bracketed paste in textinput + \ textarea Support bracketed paste in textinput + textarea Aug 19, 2022
@muesli muesli added the enhancement New feature or request label Oct 5, 2022
@knz knz changed the title Support bracketed paste in textinput + textarea feat+fix: bracketed paste in textinput + textarea, avoid corruption with ctl chars in input Jan 7, 2023
This also fixes a longstanding bug where newlines, tabs
or other control characters in the clipboard would cause
the input to be corrupted on paste.
@knz knz changed the title feat+fix: bracketed paste in textinput + textarea, avoid corruption with ctl chars in input feat+fix: bracketed paste in textinput + textarea, avoid ctl chars in clipboard input Jan 7, 2023
@knz
Copy link
Contributor Author

knz commented Jan 7, 2023

@muesli this is ready too. I have removed the inter-dependency with the other PR so that the order of release does not matter any more.

@maaslalani
Copy link
Contributor

Hey @knz! I have tested all of the examples in the Bubble Tea repo with this PR and everything looks great!

Thank you so much for this PR and contribution 🙇

@maaslalani maaslalani merged commit 53724e6 into charmbracelet:master Jan 9, 2023
@knz
Copy link
Contributor Author

knz commented Jan 9, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants