Fix Typo #300
Merged
Fix Typo #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muesli
suggested changes
Dec 3, 2022
paginator/paginator.go
Outdated
| @@ -81,7 +81,7 @@ func (m *Model) SetTotalPages(items int) int { | |||
| return n | |||
| } | |||
|
|
|||
| // ItemsOnPage is a helper function for returning the numer of items on the | |||
| // ItemsOnPage is a helper function for returning the number of items on the | |||
| // current page given the total numer of items passed as an argument. | |||
There was a problem hiding this comment.
The same typo is repeated in this line, as well as in table/table.go. Would be great to fix them all at once.
There was a problem hiding this comment.
Right.
I fixed them too.
maaslalani
approved these changes
Jan 19, 2023
maaslalani
added a commit
that referenced
this pull request
Jan 19, 2023
This reverts commit 3099851.
|
Sorry, made a type in the commit message 🤦, will leave it as I don't want to force push to |
ReallyLiri
pushed a commit
to ReallyLiri/bubbles
that referenced
this pull request
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.