feat: add option to set a custom lipgloss renderer #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
requested review from
meowgorithm,
muesli,
caarlos0 and
maaslalani
caarlos0
approved these changes
Aug 3, 2023
meowgorithm
reviewed
Aug 4, 2023
| // depending on the focus state. | ||
| // | ||
| // For an introduction to styling with Lip Gloss see: | ||
| // https://github.com/charmbracelet/lipgloss | ||
| type Style struct { | ||
| type Styles struct { |
There was a problem hiding this comment.
Any particular reason for the change here other than aesthetics?
There was a problem hiding this comment.
Consistency with other bubbles. The type alias should take care of backward compatibility.
aymanbagabas
force-pushed
the
lipgloss-renderer
branch
from
7b958c0 to
fed025b
Compare
Lip Gloss defaults to `os.Stdout` to detect the background color and color profile of the terminal. This can be a problem when the application is using a different output stream like `os.Stderr` or a remote session like in a SSH server. When using an SSH server, usually the server provides to the session a `$SSH_TTY` environment variable pointing to the allocated PTY to be used for the application. The value of `$SSH_TTY` points to the terminal TTY FD that _should_ be used to run the application. Starting with Lip Gloss v0.7, you can use custom renderers to specify a different Lip Gloss output to detect the background color and color profile. This PR adds the necessary "glue" to the Bubbles in order to change the renderer being used to detect the color profile and background.
aymanbagabas
force-pushed
the
lipgloss-renderer
branch
from
fed025b to
7bdf3e0
Compare
|
@aymanbagabas I think we can close this one? |
Let's keep it open for now until we come to a conclusion with the v2 changes |
|
looks like yes @aymanbagabas , this is gonna be fixed by bubbletea v2, right? |
Right, with the current v2, we'd still need to pass the |
|
yeah, so imo lets close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lip Gloss defaults to
os.Stdoutto detect the background color and color profile of the terminal. This can be a problem when the application is using a different output stream likeos.Stderror a remote session like in an SSH server.When using an SSH server, usually the server provides to the session a
$SSH_TTYenvironment variable pointing to the allocated PTY to be used for the application. The value of$SSH_TTYpoints to the terminal TTYFD that should be used to run the application.
Starting with Lip Gloss v0.7, you can use custom renderers to specify a different Lip Gloss output to detect the background color and color profile. This PR adds the necessary "glue" to the Bubbles in order to change the renderer being used to detect the color profile and background.