-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (textinput): do not resize based on placeholder #442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this PR @seanbanko, we really appreciate it. And thanks for your patience with getting it merged!
This throws an error in the cases where the Placeholder: Width: |
@hopefulTex thank you for catching this. I had thought that my test with I'd be glad to open another PR to fix this unless you'd prefer to; I saw you had one open yourself that may have been more robust than my solution. |
Hey @hopefulTex thank you for catching that, I had overlooked before merging. I will revert this PR and fix! |
This reverts commit 9a0ff2b.
@seanbanko I'll reopen mine since I snuck in an old paste maths fix for a different issue (cause I'm evil like that 😈) |
Co-authored-by: Sean Banko <seanbanko@Seans-MacBook-Air.local>
…rmbracelet#450) This reverts commit 9a0ff2b.
Co-authored-by: Sean Banko <seanbanko@Seans-MacBook-Air.local>
…rmbracelet#450) This reverts commit 9a0ff2b.
This PR fixes this issue regarding textinput resizing based on the placeholder. The original behavior is documented in the issue and has been modified to the following:
Placeholder = ""
Placeholder="123"
Placeholder = "1234567890"