fix(help): wrong full help sep rendering #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarlos0
approved these changes
Aug 13, 2024
|
We should add a test for this |
|
So I think this makes sense. @luevano, do you mind providing some minimal code we can use to replicate this (in addition to a test)? |
meowgorithm
requested changes
Oct 10, 2024
meowgorithm
added a commit
that referenced
this pull request
Oct 10, 2024
meowgorithm
added a commit
that referenced
this pull request
Oct 10, 2024
|
Alright, I have a test for this which I'll merge next. Thanks again for the excellent PR, and for your great patience with the one, @luevano. |
|
Hey @meowgorithm, sorry forgot about the request for the minimal code and test, been busy with work stuff lately; thanks for keeping things moving here for me! |
|
No worries, thanks again for the great PR! |
meowgorithm
added a commit
that referenced
this pull request
Oct 11, 2024
meowgorithm
added a commit
that referenced
this pull request
Oct 11, 2024
meowgorithm
added a commit
that referenced
this pull request
Oct 11, 2024
meowgorithm
added a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No matter the available horizontal space, sometimes the separator for the full help is not rendered. For example:
The issue is that the check if a separator needs to be rendered is done on
group(the column) and notgroups(the total columns). With this fixed:However, when there is enough space for the separator but not the column itself it renders the separator at the end:
This PR fixes these 2 issues and matches the behavior of the short help (adding a tail if needed/possible, rendering the separator inline, etc.). Behavior now:
