Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow to use empty style properly #683

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: allow to use empty style properly #683

wants to merge 3 commits into from

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Dec 4, 2024

alternative to #673

This way users can set the text they want using SetString in the style.

closes #673

@caarlos0
fix: allow to use empty style properly
f54c6d9 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Dec 4, 2024
@caarlos0 caarlos0 added the enhancement New feature or request label Dec 4, 2024
@caarlos0 caarlos0 marked this pull request as ready for review December 4, 2024 19:41
@caarlos0 caarlos0 requested a review from meowgorithm as a code owner December 4, 2024 19:41
@caarlos0
fix: test
6eba26a 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
bashbunni
bashbunni approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@bashbunni bashbunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbunni bashbunni bashbunni approved these changes

@aymanbagabas aymanbagabas aymanbagabas approved these changes

@meowgorithm meowgorithm Awaiting requested review from meowgorithm meowgorithm is a code owner

Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caarlos0 @aymanbagabas @bashbunni