Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cancelreader into a separate package #222

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Move cancelreader into a separate package #222

merged 1 commit into from
Apr 5, 2022

Conversation

muesli
Copy link
Contributor

@muesli muesli commented Feb 6, 2022

Cleaned up the API and docs a bit and moved CancelReader into a separate package at https://github.com/muesli/cancelreader. This hopefully gives it a bit more exposure and makes it re-usable in other projects (like termenv).

@meowgorithm
Copy link
Member

Small note there that if we do decide to merge this one it will invalidate #140, so we should consider it carefully.

@meowgorithm
Copy link
Member

@muesli #237 cancels this one out, right?

@muesli
Copy link
Contributor Author

muesli commented Apr 1, 2022

Actually, I think they complement each other quite nicely, together with a slightly adapted #258.

@bashbunni bashbunni added the enhancement New feature or request label Apr 3, 2022
@muesli muesli merged commit 515ef02 into master Apr 5, 2022
@muesli muesli deleted the cancelreader branch April 5, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants