feat: WithoutEmptyRenders #796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
naglis
reviewed
Aug 11, 2023
| @@ -166,6 +166,16 @@ func WithANSICompressor() ProgramOption { | |||
| } | |||
| } | |||
|
|
|||
| // WithoutEmptyRenders makes bubbletea do nothing when the View method return | |||
There was a problem hiding this comment.
Possible typo 😊
Suggested change
| // WithoutEmptyRenders makes bubbletea do nothing when the View method return | |
| // WithoutEmptyRenders makes bubbletea do nothing when the View method returns |
| @@ -65,7 +65,6 @@ func TestOptions(t *testing.T) { | |||
| var b bytes.Buffer | |||
| exercise(t, WithInput(&b), customInput) | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
Nitpick: change does not seem to be directly related, perhaps it was committed accidentally?
|
ended up not needing this... would it be useful to anyone? otherwise I'll close the PR. |
|
I think no need at the moment. Worst case we have the history here and we can re-open (or re-implement) if we need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experimental