feat: reduce console/term dependencies #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarlos0
approved these changes
Jan 10, 2024
|
Welp, this is awesome. Have we tested on Windows? |
|
We should also very carefully test this in combination with |
Tested it on Windows and MacOS using these examples |
aymanbagabas
force-pushed
the
reduce-term-deps
branch
from
4340b74
to
e086d98
Compare
caarlos0
reviewed
Feb 8, 2024
aymanbagabas
force-pushed
the
reduce-term-deps
branch
2 times, most recently
from
ee06175
to
45e8153
Compare
meowgorithm
approved these changes
Mar 1, 2024
aymanbagabas
force-pushed
the
reduce-term-deps
branch
2 times, most recently
from
414f447
to
da47186
Compare
Replace mattn/isatty and containerd/console with golang.org/x/term. This mostly affects Windows. On Windows, unlike Unix, the console (TTY) has different handles for input/output. Using the Console API, we need to enable VT input on the input handle (CONIN) and VT processing on the output handle (CONOUT). Doing so enables processing VT sequences on Windows i.e. ANSI colors, mouse sequences, cursor movements, etc. We already handle enabling VT processing for the program output using Termenv `EnableVirtualTerminalProcessing`. For the input side, we enable VT input right before setting the console to raw. By doing this, we can drop both containerd/console and mattn/isatty.
aymanbagabas
force-pushed
the
reduce-term-deps
branch
from
da47186
to
c0a09d6
Compare
another-rex
pushed a commit
to google/osv-scanner
that referenced
this pull request
May 6, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [deps.dev/api/v3](https://github.com/google/deps.dev) | `v3.0.0-20240411010756-f6f382da6e02` -> `v3.0.0-20240503042720-6166138ce783` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [deps.dev/util/maven](https://github.com/google/deps.dev) | `v0.0.0-20240411010756-f6f382da6e02` -> `v0.0.0-20240503042720-6166138ce783` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [deps.dev/util/resolve](https://github.com/google/deps.dev) | `v0.0.0-20240411010756-f6f382da6e02` -> `v0.0.0-20240503042720-6166138ce783` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [deps.dev/util/semver](https://github.com/google/deps.dev) | `v0.0.0-20240411010756-f6f382da6e02` -> `v0.0.0-20240503042720-6166138ce783` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/charmbracelet/bubbletea](https://github.com/charmbracelet/bubbletea) | `v0.25.0` -> `v0.26.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/gkampitakis/go-snaps](https://github.com/gkampitakis/go-snaps) | `v0.5.3` -> `v0.5.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/jedib0t/go-pretty/v6](https://github.com/jedib0t/go-pretty) | `v6.5.8` -> `v6.5.9` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/urfave/cli/v2](https://github.com/urfave/cli) | `v2.27.1` -> `v2.27.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | golang.org/x/term | `v0.19.0` -> `v0.20.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) | `v1.33.0` -> `v1.34.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charmbracelet/bubbletea (github.com/charmbracelet/bubbletea)</summary> ### [`v0.26.1`](https://github.com/charmbracelet/bubbletea/releases/tag/v0.26.1) [Compare Source](https://github.com/charmbracelet/bubbletea/compare/v0.26.0...v0.26.1) This is a quick one to fix a Windows shortcoming in the last release acutely identified by our pal [@​jon4hz](https://github.com/jon4hz). Thank you! #### What's Changed - fix: support more shift and ctrl modifiers on windows by [@​jon4hz](https://github.com/jon4hz) in [charmbracelet/bubbletea#995 **Full Changelog**: charmbracelet/bubbletea@v0.26.0...v0.26.1 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.social/@​charmcli), or [Discord](https://charm.sh/chat). ### [`v0.26.0`](https://github.com/charmbracelet/bubbletea/releases/tag/v0.26.0) [Compare Source](https://github.com/charmbracelet/bubbletea/compare/v0.25.0...v0.26.0) ### Bracketed Paste, Windows Improvements, Mainframes, and more What do tapioca balls, IBM mainframes, and the Microsoft Windows Console API have in common? Bubble Tea v0.26.0, that’s what. Let’s get to it. #### ⚡️ Windows Input Improvements A few years ago [@​erikgeiser](https://github.com/erikgeiser), a penetration tester and ex-particle physicist, wrote this awesome library called [coninput](https://github.com/erikgeiser/coninput) to majorly improve Bubble Tea input on Windows. [@​aymanbagabas](https://github.com/aymanbagabas) has implemented the library in Bubble Tea and input on Windows is roughly 1000 times better now. In the short term, this means that for Windows users inputting non-Latin characters (like Greek, Cyrillic, Korean, Chinese and so on) stuff will “just work.” The bigger news, however, is that this paves the way for Windows parity with our forthcoming support for super high fidelity input via [Kitty Keyboard](https://sw.kovidgoyal.net/kitty/keyboard-protocol/) and [Fixterms](https://www.leonerd.org.uk/hacks/fixterms/). #### 🍳 Hot Windows Resize Events Terminal emulators on Windows don’t support the `SIGWINCH` signal, which is sent when the terminal is resized. It’s been a huge bummer for a really long time. Thanks (again) to [@​erikgeiser](https://github.com/erikgeiser) and [@​aymanbagabas](https://github.com/aymanbagabas), we’re now able to reach deep into Windows’ underpinnings, detect window resizes, and send [`tea.WindowSizeMsg`](https://pkg.go.dev/github.com/charmbracelet/bubbletea@v0.26.0#WindowSizeMsg)s accordingly! This is a glorious moment for Bubble Tea on Windows indeed. #### 🫠 Bracketed Paste While building a query editor for a CockroachDB client, [@​knz](https://github.com/knz) noticed that Bubble Tea didn't support [Bracketed Paste](https://cirw.in/blog/bracketed-paste). Performance-wise, that sucks because it means pasting large bodies of text (like SQL queries) will normally be seen as a bunch of little successive keypresses. That’s where Bracketed Paste comes in. When enabled at the terminal-level Bracketed Paste lets you slam down a bunch of text with one big, fat input event. Bubble Tea enables bracketed paste by default, however you can opt out of it with the [`WithoutBracketedPaste()`](https://pkg.go.dev/github.com/charmbracelet/bubbletea@v0.26.0#WithoutBracketedPaste) program option: ```go p := tea.NewProgram(myCuteModel, tea.WithoutBracketedPaste()) ``` You can also enable and disable it on demand with the [`EnableBracketedPaste()`](https://pkg.go.dev/github.com/charmbracelet/bubbletea@v0.26.0#EnableBracketedPaste) and [`DisableBracketedPaste()`](https://pkg.go.dev/github.com/charmbracelet/bubbletea@v0.26.0#DisableBracketedPaste) commands. #### 🌿 Multiline `tea.Println` In case you forgot, [`tea.Println`](https://pkg.go.dev/github.com/charmbracelet/bubbletea@v0.26.0#Println) (and it’s brother [`tea.Printf`](https://pkg.go.dev/github.com/charmbracelet/bubbletea@v0.26.0#Printf)) is a `Cmd` that lets you print unmanaged output above a Bubble Tea program, similar to what you see with package managers like `apt-get`. Thanks to [@​Adjective-Object](https://github.com/Adjective-Object) (who also implemented `tea.Println` in the first place) now you can send multi-line output, too. For a `tea.Println` refresher see [the package manager example](https://github.com/charmbracelet/bubbletea/tree/master/examples/package-manager). #### 📀 Hello, z/OS Don’t you think it’s about time we all ran Bubble Tea apps on our mainframes? Thanks to [@​dustin-ward](https://github.com/dustin-ward) that dream is now a reality, so long as you have a [z/OS](https://www.ibm.com/products/zos) mainframe. We're thrilled to announce that Bubble Tea is now fully supported on z/OS. #### 🌹 Bug fixes Bugfixes are the unsung heroes that sometimes get buried below the feature listings. This release has them and they’re good ones; see the changelog below for details. #### Changelog ##### New! - bracketed paste by [@​knz](https://github.com/knz) in [charmbracelet/bubbletea#397 - use windows console input buffer + resize events on windows by [@​aymanbagabas](https://github.com/aymanbagabas) in [charmbracelet/bubbletea#878 - multiline `tea.Println()` messages by [@​Adjective-Object](https://github.com/Adjective-Object) in [charmbracelet/bubbletea#490 - z/OS support by [@​dustin-ward](https://github.com/dustin-ward) in [charmbracelet/bubbletea#913 ##### Changed - use go 1.18; update bubbles by [@​caarlos0](https://github.com/caarlos0) in [charmbracelet/bubbletea#916 ##### Fixed - fix deadlock condition on model init panic by [@​eolso](https://github.com/eolso) in [charmbracelet/bubbletea#926 - reduce console/term dependencies by [@​aymanbagabas](https://github.com/aymanbagabas) in [charmbracelet/bubbletea#897 - optimize batches with one item by [@​systay](https://github.com/systay) in [charmbracelet/bubbletea#875 ##### New Contributors - [@​kevgo](https://github.com/kevgo) made their first contribution in [charmbracelet/bubbletea#893 - [@​canack](https://github.com/canack) made their first contribution in [charmbracelet/bubbletea#890 - [@​Pheon-Dev](https://github.com/Pheon-Dev) made their first contribution in [charmbracelet/bubbletea#621 - [@​rusinikita](https://github.com/rusinikita) made their first contribution in [charmbracelet/bubbletea#835 - [@​hedhyw](https://github.com/hedhyw) made their first contribution in [charmbracelet/bubbletea#864 - [@​mat2cc](https://github.com/mat2cc) made their first contribution in [charmbracelet/bubbletea#871 - [@​stefanlogue](https://github.com/stefanlogue) made their first contribution in [charmbracelet/bubbletea#855 - [@​BigJk](https://github.com/BigJk) made their first contribution in [charmbracelet/bubbletea#885 - [@​sharunkumar](https://github.com/sharunkumar) made their first contribution in [charmbracelet/bubbletea#839 - [@​timmattison](https://github.com/timmattison) made their first contribution in [charmbracelet/bubbletea#908 - [@​dustin-ward](https://github.com/dustin-ward) made their first contribution in [charmbracelet/bubbletea#913 - [@​jaymorelli96](https://github.com/jaymorelli96) made their first contribution in [charmbracelet/bubbletea#802 - [@​siddhantac](https://github.com/siddhantac) made their first contribution in [charmbracelet/bubbletea#906 - [@​taigrr](https://github.com/taigrr) made their first contribution in [charmbracelet/bubbletea#853 - [@​systay](https://github.com/systay) made their first contribution in [charmbracelet/bubbletea#875 - [@​gabe565](https://github.com/gabe565) made their first contribution in [charmbracelet/bubbletea#728 - [@​zMoooooritz](https://github.com/zMoooooritz) made their first contribution in [charmbracelet/bubbletea#902 - [@​j178](https://github.com/j178) made their first contribution in [charmbracelet/bubbletea#709 - [@​arisnacg](https://github.com/arisnacg) made their first contribution in [charmbracelet/bubbletea#948 - [@​braheezy](https://github.com/braheezy) made their first contribution in [charmbracelet/bubbletea#950 - [@​dhth](https://github.com/dhth) made their first contribution in [charmbracelet/bubbletea#949 - [@​tearingItUp786](https://github.com/tearingItUp786) made their first contribution in [charmbracelet/bubbletea#944 - [@​aschey](https://github.com/aschey) made their first contribution in [charmbracelet/bubbletea#597 - [@​petergloor](https://github.com/petergloor) made their first contribution in [charmbracelet/bubbletea#955 - [@​kaifulee](https://github.com/kaifulee) made their first contribution in [charmbracelet/bubbletea#957 - [@​danenania](https://github.com/danenania) made their first contribution in [charmbracelet/bubbletea#971 - [@​cuibuwei](https://github.com/cuibuwei) made their first contribution in [charmbracelet/bubbletea#977 - [@​agvxov](https://github.com/agvxov) made their first contribution in [charmbracelet/bubbletea#972 - [@​eolso](https://github.com/eolso) made their first contribution in [charmbracelet/bubbletea#926 **Full Changelog**: charmbracelet/bubbletea@v0.25.0...v0.25.1 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.social/@​charmcli), or [Discord](https://charm.sh/chat). </details> <details> <summary>gkampitakis/go-snaps (github.com/gkampitakis/go-snaps)</summary> ### [`v0.5.4`](https://github.com/gkampitakis/go-snaps/releases/tag/v0.5.4) [Compare Source](https://github.com/gkampitakis/go-snaps/compare/v0.5.3...v0.5.4) #### What's Changed - fix: slice bounds out of range \[:5] by [@​zregvart](https://github.com/zregvart) in [gkampitakis/go-snaps#98 #### New Contributors - [@​zregvart](https://github.com/zregvart) made their first contribution in [gkampitakis/go-snaps#98 **Full Changelog**: gkampitakis/go-snaps@v0.5.3...v0.5.4 </details> <details> <summary>jedib0t/go-pretty (github.com/jedib0t/go-pretty/v6)</summary> ### [`v6.5.9`](https://github.com/jedib0t/go-pretty/releases/tag/v6.5.9) [Compare Source](https://github.com/jedib0t/go-pretty/compare/v6.5.8...v6.5.9) #### What's Changed - table: html row automerge support by [@​hindessm](https://github.com/hindessm) in [jedib0t/go-pretty#319 - table: update note about auto-merge by [@​hindessm](https://github.com/hindessm) in [jedib0t/go-pretty#320 #### New Contributors - [@​hindessm](https://github.com/hindessm) made their first contribution in [jedib0t/go-pretty#319 **Full Changelog**: jedib0t/go-pretty@v6.5.8...v6.5.9 </details> <details> <summary>urfave/cli (github.com/urfave/cli/v2)</summary> ### [`v2.27.2`](https://github.com/urfave/cli/releases/tag/v2.27.2) [Compare Source](https://github.com/urfave/cli/compare/v2.27.1...v2.27.2) #### What's Changed - Cleanup: Remove unnecessary intermediate variables by [@​1ambd4](https://github.com/1ambd4) in [urfave/cli#1857 - Docs:(issue\_1866) Fix documentation on filepath vs env preference by [@​dearchap](https://github.com/dearchap) in [urfave/cli#1867 - Fix:(issue\_1860) Remove hidden flags from flag categories by [@​dearchap](https://github.com/dearchap) in [urfave/cli#1868 - Fix repeated \[arguments...] in usage template in v2 by [@​edeustua](https://github.com/edeustua) in [urfave/cli#1872 - Update dependencies, actions steps, and usage for v2-maint by [@​meatballhat](https://github.com/meatballhat) in [urfave/cli#1888 #### New Contributors - [@​1ambd4](https://github.com/1ambd4) made their first contribution in [urfave/cli#1857 - [@​edeustua](https://github.com/edeustua) made their first contribution in [urfave/cli#1872 **Full Changelog**: urfave/cli@v2.27.1...v2.27.2 </details> <details> <summary>protocolbuffers/protobuf-go (google.golang.org/protobuf)</summary> ### [`v1.34.0`](https://github.com/protocolbuffers/protobuf-go/compare/v1.33.0...v1.34.0) [Compare Source](https://github.com/protocolbuffers/protobuf-go/compare/v1.33.0...v1.34.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM0MC4xMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->
aymanbagabas
added a commit
that referenced
this pull request
May 8, 2024
Before switching to golang/term for terminal handling, we used containerd/console. Which by default, uses Termios OPOST when setting the terminal to raw mode. This is needed because we need to post process output to render the terminal correctly. This also switches to using charmbracelet/x/exp/term since golang/term doesn't allow setting a custom Termios settings. Fixes: #1000 Fixes: 4624106 (feat: reduce console/term dependencies (#897))
aymanbagabas
added a commit
that referenced
this pull request
May 8, 2024
Before switching to golang/term for terminal handling, we used containerd/console. Which by default, uses Termios OPOST when setting the terminal to raw mode. This is needed because we need to post process output to render the terminal correctly. This also switches to using charmbracelet/x/exp/term since golang/term doesn't allow setting a custom Termios settings. Fixes: #1000 Fixes: 4624106 (feat: reduce console/term dependencies (#897))
josieang
pushed a commit
to josieang/osv-scanner
that referenced
this pull request
Jun 6, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [deps.dev/api/v3](https://github.com/google/deps.dev) | `v3.0.0-20240411010756-f6f382da6e02` -> `v3.0.0-20240503042720-6166138ce783` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [deps.dev/util/maven](https://github.com/google/deps.dev) | `v0.0.0-20240411010756-f6f382da6e02` -> `v0.0.0-20240503042720-6166138ce783` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [deps.dev/util/resolve](https://github.com/google/deps.dev) | `v0.0.0-20240411010756-f6f382da6e02` -> `v0.0.0-20240503042720-6166138ce783` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [deps.dev/util/semver](https://github.com/google/deps.dev) | `v0.0.0-20240411010756-f6f382da6e02` -> `v0.0.0-20240503042720-6166138ce783` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/charmbracelet/bubbletea](https://github.com/charmbracelet/bubbletea) | `v0.25.0` -> `v0.26.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/gkampitakis/go-snaps](https://github.com/gkampitakis/go-snaps) | `v0.5.3` -> `v0.5.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/jedib0t/go-pretty/v6](https://github.com/jedib0t/go-pretty) | `v6.5.8` -> `v6.5.9` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/urfave/cli/v2](https://github.com/urfave/cli) | `v2.27.1` -> `v2.27.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | golang.org/x/term | `v0.19.0` -> `v0.20.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) | `v1.33.0` -> `v1.34.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charmbracelet/bubbletea (github.com/charmbracelet/bubbletea)</summary> ### [`v0.26.1`](https://github.com/charmbracelet/bubbletea/releases/tag/v0.26.1) [Compare Source](https://github.com/charmbracelet/bubbletea/compare/v0.26.0...v0.26.1) This is a quick one to fix a Windows shortcoming in the last release acutely identified by our pal [@​jon4hz](https://github.com/jon4hz). Thank you! #### What's Changed - fix: support more shift and ctrl modifiers on windows by [@​jon4hz](https://github.com/jon4hz) in [charmbracelet/bubbletea#995 **Full Changelog**: charmbracelet/bubbletea@v0.26.0...v0.26.1 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.social/@​charmcli), or [Discord](https://charm.sh/chat). ### [`v0.26.0`](https://github.com/charmbracelet/bubbletea/releases/tag/v0.26.0) [Compare Source](https://github.com/charmbracelet/bubbletea/compare/v0.25.0...v0.26.0) ### Bracketed Paste, Windows Improvements, Mainframes, and more What do tapioca balls, IBM mainframes, and the Microsoft Windows Console API have in common? Bubble Tea v0.26.0, that’s what. Let’s get to it. #### ⚡️ Windows Input Improvements A few years ago [@​erikgeiser](https://github.com/erikgeiser), a penetration tester and ex-particle physicist, wrote this awesome library called [coninput](https://github.com/erikgeiser/coninput) to majorly improve Bubble Tea input on Windows. [@​aymanbagabas](https://github.com/aymanbagabas) has implemented the library in Bubble Tea and input on Windows is roughly 1000 times better now. In the short term, this means that for Windows users inputting non-Latin characters (like Greek, Cyrillic, Korean, Chinese and so on) stuff will “just work.” The bigger news, however, is that this paves the way for Windows parity with our forthcoming support for super high fidelity input via [Kitty Keyboard](https://sw.kovidgoyal.net/kitty/keyboard-protocol/) and [Fixterms](https://www.leonerd.org.uk/hacks/fixterms/). #### 🍳 Hot Windows Resize Events Terminal emulators on Windows don’t support the `SIGWINCH` signal, which is sent when the terminal is resized. It’s been a huge bummer for a really long time. Thanks (again) to [@​erikgeiser](https://github.com/erikgeiser) and [@​aymanbagabas](https://github.com/aymanbagabas), we’re now able to reach deep into Windows’ underpinnings, detect window resizes, and send [`tea.WindowSizeMsg`](https://pkg.go.dev/github.com/charmbracelet/bubbletea@v0.26.0#WindowSizeMsg)s accordingly! This is a glorious moment for Bubble Tea on Windows indeed. #### 🫠 Bracketed Paste While building a query editor for a CockroachDB client, [@​knz](https://github.com/knz) noticed that Bubble Tea didn't support [Bracketed Paste](https://cirw.in/blog/bracketed-paste). Performance-wise, that sucks because it means pasting large bodies of text (like SQL queries) will normally be seen as a bunch of little successive keypresses. That’s where Bracketed Paste comes in. When enabled at the terminal-level Bracketed Paste lets you slam down a bunch of text with one big, fat input event. Bubble Tea enables bracketed paste by default, however you can opt out of it with the [`WithoutBracketedPaste()`](https://pkg.go.dev/github.com/charmbracelet/bubbletea@v0.26.0#WithoutBracketedPaste) program option: ```go p := tea.NewProgram(myCuteModel, tea.WithoutBracketedPaste()) ``` You can also enable and disable it on demand with the [`EnableBracketedPaste()`](https://pkg.go.dev/github.com/charmbracelet/bubbletea@v0.26.0#EnableBracketedPaste) and [`DisableBracketedPaste()`](https://pkg.go.dev/github.com/charmbracelet/bubbletea@v0.26.0#DisableBracketedPaste) commands. #### 🌿 Multiline `tea.Println` In case you forgot, [`tea.Println`](https://pkg.go.dev/github.com/charmbracelet/bubbletea@v0.26.0#Println) (and it’s brother [`tea.Printf`](https://pkg.go.dev/github.com/charmbracelet/bubbletea@v0.26.0#Printf)) is a `Cmd` that lets you print unmanaged output above a Bubble Tea program, similar to what you see with package managers like `apt-get`. Thanks to [@​Adjective-Object](https://github.com/Adjective-Object) (who also implemented `tea.Println` in the first place) now you can send multi-line output, too. For a `tea.Println` refresher see [the package manager example](https://github.com/charmbracelet/bubbletea/tree/master/examples/package-manager). #### 📀 Hello, z/OS Don’t you think it’s about time we all ran Bubble Tea apps on our mainframes? Thanks to [@​dustin-ward](https://github.com/dustin-ward) that dream is now a reality, so long as you have a [z/OS](https://www.ibm.com/products/zos) mainframe. We're thrilled to announce that Bubble Tea is now fully supported on z/OS. #### 🌹 Bug fixes Bugfixes are the unsung heroes that sometimes get buried below the feature listings. This release has them and they’re good ones; see the changelog below for details. #### Changelog ##### New! - bracketed paste by [@​knz](https://github.com/knz) in [charmbracelet/bubbletea#397 - use windows console input buffer + resize events on windows by [@​aymanbagabas](https://github.com/aymanbagabas) in [charmbracelet/bubbletea#878 - multiline `tea.Println()` messages by [@​Adjective-Object](https://github.com/Adjective-Object) in [charmbracelet/bubbletea#490 - z/OS support by [@​dustin-ward](https://github.com/dustin-ward) in [charmbracelet/bubbletea#913 ##### Changed - use go 1.18; update bubbles by [@​caarlos0](https://github.com/caarlos0) in [charmbracelet/bubbletea#916 ##### Fixed - fix deadlock condition on model init panic by [@​eolso](https://github.com/eolso) in [charmbracelet/bubbletea#926 - reduce console/term dependencies by [@​aymanbagabas](https://github.com/aymanbagabas) in [charmbracelet/bubbletea#897 - optimize batches with one item by [@​systay](https://github.com/systay) in [charmbracelet/bubbletea#875 ##### New Contributors - [@​kevgo](https://github.com/kevgo) made their first contribution in [charmbracelet/bubbletea#893 - [@​canack](https://github.com/canack) made their first contribution in [charmbracelet/bubbletea#890 - [@​Pheon-Dev](https://github.com/Pheon-Dev) made their first contribution in [charmbracelet/bubbletea#621 - [@​rusinikita](https://github.com/rusinikita) made their first contribution in [charmbracelet/bubbletea#835 - [@​hedhyw](https://github.com/hedhyw) made their first contribution in [charmbracelet/bubbletea#864 - [@​mat2cc](https://github.com/mat2cc) made their first contribution in [charmbracelet/bubbletea#871 - [@​stefanlogue](https://github.com/stefanlogue) made their first contribution in [charmbracelet/bubbletea#855 - [@​BigJk](https://github.com/BigJk) made their first contribution in [charmbracelet/bubbletea#885 - [@​sharunkumar](https://github.com/sharunkumar) made their first contribution in [charmbracelet/bubbletea#839 - [@​timmattison](https://github.com/timmattison) made their first contribution in [charmbracelet/bubbletea#908 - [@​dustin-ward](https://github.com/dustin-ward) made their first contribution in [charmbracelet/bubbletea#913 - [@​jaymorelli96](https://github.com/jaymorelli96) made their first contribution in [charmbracelet/bubbletea#802 - [@​siddhantac](https://github.com/siddhantac) made their first contribution in [charmbracelet/bubbletea#906 - [@​taigrr](https://github.com/taigrr) made their first contribution in [charmbracelet/bubbletea#853 - [@​systay](https://github.com/systay) made their first contribution in [charmbracelet/bubbletea#875 - [@​gabe565](https://github.com/gabe565) made their first contribution in [charmbracelet/bubbletea#728 - [@​zMoooooritz](https://github.com/zMoooooritz) made their first contribution in [charmbracelet/bubbletea#902 - [@​j178](https://github.com/j178) made their first contribution in [charmbracelet/bubbletea#709 - [@​arisnacg](https://github.com/arisnacg) made their first contribution in [charmbracelet/bubbletea#948 - [@​braheezy](https://github.com/braheezy) made their first contribution in [charmbracelet/bubbletea#950 - [@​dhth](https://github.com/dhth) made their first contribution in [charmbracelet/bubbletea#949 - [@​tearingItUp786](https://github.com/tearingItUp786) made their first contribution in [charmbracelet/bubbletea#944 - [@​aschey](https://github.com/aschey) made their first contribution in [charmbracelet/bubbletea#597 - [@​petergloor](https://github.com/petergloor) made their first contribution in [charmbracelet/bubbletea#955 - [@​kaifulee](https://github.com/kaifulee) made their first contribution in [charmbracelet/bubbletea#957 - [@​danenania](https://github.com/danenania) made their first contribution in [charmbracelet/bubbletea#971 - [@​cuibuwei](https://github.com/cuibuwei) made their first contribution in [charmbracelet/bubbletea#977 - [@​agvxov](https://github.com/agvxov) made their first contribution in [charmbracelet/bubbletea#972 - [@​eolso](https://github.com/eolso) made their first contribution in [charmbracelet/bubbletea#926 **Full Changelog**: charmbracelet/bubbletea@v0.25.0...v0.25.1 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.social/@​charmcli), or [Discord](https://charm.sh/chat). </details> <details> <summary>gkampitakis/go-snaps (github.com/gkampitakis/go-snaps)</summary> ### [`v0.5.4`](https://github.com/gkampitakis/go-snaps/releases/tag/v0.5.4) [Compare Source](https://github.com/gkampitakis/go-snaps/compare/v0.5.3...v0.5.4) #### What's Changed - fix: slice bounds out of range \[:5] by [@​zregvart](https://github.com/zregvart) in [gkampitakis/go-snaps#98 #### New Contributors - [@​zregvart](https://github.com/zregvart) made their first contribution in [gkampitakis/go-snaps#98 **Full Changelog**: gkampitakis/go-snaps@v0.5.3...v0.5.4 </details> <details> <summary>jedib0t/go-pretty (github.com/jedib0t/go-pretty/v6)</summary> ### [`v6.5.9`](https://github.com/jedib0t/go-pretty/releases/tag/v6.5.9) [Compare Source](https://github.com/jedib0t/go-pretty/compare/v6.5.8...v6.5.9) #### What's Changed - table: html row automerge support by [@​hindessm](https://github.com/hindessm) in [jedib0t/go-pretty#319 - table: update note about auto-merge by [@​hindessm](https://github.com/hindessm) in [jedib0t/go-pretty#320 #### New Contributors - [@​hindessm](https://github.com/hindessm) made their first contribution in [jedib0t/go-pretty#319 **Full Changelog**: jedib0t/go-pretty@v6.5.8...v6.5.9 </details> <details> <summary>urfave/cli (github.com/urfave/cli/v2)</summary> ### [`v2.27.2`](https://github.com/urfave/cli/releases/tag/v2.27.2) [Compare Source](https://github.com/urfave/cli/compare/v2.27.1...v2.27.2) #### What's Changed - Cleanup: Remove unnecessary intermediate variables by [@​1ambd4](https://github.com/1ambd4) in [urfave/cli#1857 - Docs:(issue\_1866) Fix documentation on filepath vs env preference by [@​dearchap](https://github.com/dearchap) in [urfave/cli#1867 - Fix:(issue\_1860) Remove hidden flags from flag categories by [@​dearchap](https://github.com/dearchap) in [urfave/cli#1868 - Fix repeated \[arguments...] in usage template in v2 by [@​edeustua](https://github.com/edeustua) in [urfave/cli#1872 - Update dependencies, actions steps, and usage for v2-maint by [@​meatballhat](https://github.com/meatballhat) in [urfave/cli#1888 #### New Contributors - [@​1ambd4](https://github.com/1ambd4) made their first contribution in [urfave/cli#1857 - [@​edeustua](https://github.com/edeustua) made their first contribution in [urfave/cli#1872 **Full Changelog**: urfave/cli@v2.27.1...v2.27.2 </details> <details> <summary>protocolbuffers/protobuf-go (google.golang.org/protobuf)</summary> ### [`v1.34.0`](https://github.com/protocolbuffers/protobuf-go/compare/v1.33.0...v1.34.0) [Compare Source](https://github.com/protocolbuffers/protobuf-go/compare/v1.33.0...v1.34.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM0MC4xMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace mattn/isatty and containerd/console with golang.org/x/term.
This mostly affects Windows. On Windows, unlike Unix, the console (TTY) has different handles for input/output. Using the Console API, we need to enable VT input on the input handle (CONIN) and VT processing on the output handle (CONOUT). Doing so enables processing VT sequences on Windows i.e. ANSI colors, mouse sequences, cursor movements, etc.
We already handle enabling VT processing for the program output using Termenv
EnableVirtualTerminalProcessing. For the input side, we enable VT input right before setting the console to raw.By doing this, we can drop both containerd/console and mattn/isatty.