refactor: replace props map with struct fields #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
who-needs-copy
branch
2 times, most recently
from
8c95fd7
to
7832119
Compare
aymanbagabas
force-pushed
the
who-needs-copy
branch
from
7832119
to
387f2d7
Compare
meowgorithm
approved these changes
May 1, 2024
meowgorithm
reviewed
May 1, 2024
Co-authored-by: Christian Rocha <christian@rocha.is>
maaslalani
approved these changes
May 1, 2024
|
Tested all of the bubbletea examples, looks good to me! |
caarlos0
approved these changes
May 2, 2024
another-rex
referenced
this pull request
in google/osv-scanner
May 27, 2024
Renovate + Also Remove/updates some deprecated function calls [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [github.com/BurntSushi/toml](https://github.com/BurntSushi/toml) | `v1.3.2` -> `v1.4.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [github.com/charmbracelet/bubbletea](https://github.com/charmbracelet/bubbletea) | `v0.26.2` -> `v0.26.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/charmbracelet/lipgloss](https://github.com/charmbracelet/lipgloss) | `v0.10.0` -> `v0.11.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | golang.org/x/exp | `9bf2ced` -> `4c93da0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | digest | --- ### Release Notes <details> <summary>BurntSushi/toml (github.com/BurntSushi/toml)</summary> ### [`v1.4.0`](https://github.com/BurntSushi/toml/releases/tag/v1.4.0) [Compare Source](https://github.com/BurntSushi/toml/compare/v1.3.2...v1.4.0) This version requires Go 1.18 - Add toml.Marshal() ([#​405](https://github.com/BurntSushi/toml/issues/405)) - Require 2-digit hour ([#​320](https://github.com/BurntSushi/toml/issues/320)) - Wrap UnmarshalTOML() and UnmarshalText() return values in ParseError for position information ([#​398](https://github.com/BurntSushi/toml/issues/398)) - Fix inline tables with dotted keys inside inline arrays (e.g. `k=[{a.b=1}]`) ([#​400](https://github.com/BurntSushi/toml/issues/400)) </details> <details> <summary>charmbracelet/bubbletea (github.com/charmbracelet/bubbletea)</summary> ### [`v0.26.3`](https://github.com/charmbracelet/bubbletea/releases/tag/v0.26.3) [Compare Source](https://github.com/charmbracelet/bubbletea/compare/v0.26.2...v0.26.3) This is a patch release that prevents `tea.WindowSizeMsg`s from being fired during altscreen changes on Windows. This was due to the fact that Windows emits a `window-size-event` on altscreen changes even if the size hand’t changed. Now, we cache the window-size and compare before sending the message to the `Model`. #### What's Changed - Prevent multiple window-size-events from firing on Windows by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/bubbletea/pull/1021](https://github.com/charmbracelet/bubbletea/pull/1021) - refactor: use x/term and x/ansi for renderer sequences by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/bubbletea/pull/962](https://github.com/charmbracelet/bubbletea/pull/962) **Full Changelog**: charmbracelet/bubbletea@v0.26.2...v0.26.3 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.social/@​charmcli), or [Discord](https://charm.sh/chat). </details> <details> <summary>charmbracelet/lipgloss (github.com/charmbracelet/lipgloss)</summary> ### [`v0.11.0`](https://github.com/charmbracelet/lipgloss/releases/tag/v0.11.0) [Compare Source](https://github.com/charmbracelet/lipgloss/compare/v0.10.0...v0.11.0) ### Immutable Styles and Raw Speed, Baby So! The big news in this release is: - `Style` methods will now *always* return new styles - `Style` and ANSI operations under the hood are faster There are also a handful of great lil' bug fixes. Read on for more. #### Immutable Styles Every `Style` method now returns a completely new style with its own underlying data structure no matter what. This means working with Styles is a lot easier. No more need for `Copy()`! ```go // Before s := lipgloss.NewStyle().Bold(true) newStyle := s.Copy() // After s := lipgloss.NewStyle().Bold(true) newStyle := s // this is a true copy ``` Okay, but why are styles easier to work with now? Consider this: ```go // Before baseStyle := lipgloss.NewStyle().Background(lipgloss.Color("59")) styleAtRuntime := baseStyle.Copy().Width(m.Width) // After baseStyle := lipgloss.NewStyle().Padding(1, 2) styleAtRuntime := baseStyle.Width(m.Width) ``` It might seem small, but eliminating the risk of mutations in persistent styles in an enormous usability improvement. ##### How to upgrade There's nothing to do, however `Style.Copy()` is now deprecated and only returns itself, so you can just remove `Style.Copy()` calls. If you need to *just* copy a style without any changes to it you can simply `b := a`. #### Faster ANSI Sometimes watch companies brag about their "in-house" watch movement. Well, now we're bragging about our in-house-amazing [`x/ansi`](https://github.com/charmbracelet/x/tree/main/ansi) library by our own [@​aymanbagabas](https://github.com/aymanbagabas). It's a fine-tuned, low-level way to manage ANSI sequencing and, because we're pretty nerdy, we’re *super* excited about it. *** #### What's Changed ##### New! - always return copies of styles by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/lipgloss/pull/276](https://github.com/charmbracelet/lipgloss/pull/276) ##### Changed - switch to term/ansi for text manipulation by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/lipgloss/pull/268](https://github.com/charmbracelet/lipgloss/pull/268) - replace stripansi with ansi.Strip in table by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/lipgloss/pull/271](https://github.com/charmbracelet/lipgloss/pull/271) - test for different GOOS & GOARCH by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/lipgloss/pull/292](https://github.com/charmbracelet/lipgloss/pull/292) ##### Fixed - fix combining both conditional and unconditional wrapping by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/lipgloss/pull/275](https://github.com/charmbracelet/lipgloss/pull/275) - fix UnderlineSpaces and StrikethroughSpaces by [@​Taz03](https://github.com/Taz03) in [https://github.com/charmbracelet/lipgloss/pull/299](https://github.com/charmbracelet/lipgloss/pull/299) - always render horizontal border edges when enabled by [@​UnseenBook](https://github.com/UnseenBook) in [https://github.com/charmbracelet/lipgloss/pull/211](https://github.com/charmbracelet/lipgloss/pull/211) - fix possible nil panic by [@​maaslalani](https://github.com/maaslalani) in [https://github.com/charmbracelet/lipgloss/pull/245](https://github.com/charmbracelet/lipgloss/pull/245) - fix transform operating on ANSI sequences by [@​meowgorithm](https://github.com/meowgorithm) in [https://github.com/charmbracelet/lipgloss/pull/274](https://github.com/charmbracelet/lipgloss/pull/274) - change propkeys from int to int64 by [@​hugoleodev](https://github.com/hugoleodev) in [https://github.com/charmbracelet/lipgloss/pull/291](https://github.com/charmbracelet/lipgloss/pull/291) #### New Contributors - [@​benwaffle](https://github.com/benwaffle) made their first contribution in [https://github.com/charmbracelet/lipgloss/pull/247](https://github.com/charmbracelet/lipgloss/pull/247) - [@​UnseenBook](https://github.com/UnseenBook) made their first contribution in [https://github.com/charmbracelet/lipgloss/pull/211](https://github.com/charmbracelet/lipgloss/pull/211) - [@​hugoleodev](https://github.com/hugoleodev) made their first contribution in [https://github.com/charmbracelet/lipgloss/pull/291](https://github.com/charmbracelet/lipgloss/pull/291) - [@​Taz03](https://github.com/Taz03) made their first contribution in [https://github.com/charmbracelet/lipgloss/pull/299](https://github.com/charmbracelet/lipgloss/pull/299) **Full Changelog**: charmbracelet/lipgloss@v0.10.0...v0.11.0 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.technology/@​charm), or [Discord](https://charm.sh/discord). </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==--> --------- Co-authored-by: Rex P <rexpan@google.com>
renovate bot
referenced
this pull request
in jippi/dottie
Jun 5, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/charmbracelet/huh](https://github.com/charmbracelet/huh) | `v0.3.0` -> `v0.4.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/charmbracelet/lipgloss](https://github.com/charmbracelet/lipgloss) | `v0.10.0` -> `v0.11.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charmbracelet/huh (github.com/charmbracelet/huh)</summary> ### [`v0.4.2`](https://github.com/charmbracelet/huh/releases/tag/v0.4.2) [Compare Source](https://github.com/charmbracelet/huh/compare/v0.4.1...v0.4.2) ### Your favourite files 📁 Huh? `v0.4.0` (`v0.4.2`) introduces the File Picker to forms ✨ Prompt users to select a file in just a few lines of code, you know the drill :) ```go var file string huh.NewFilePicker(). Title("Select a file:"). Description("This will be your profile image."). AllowedTypes([]string{".png", ".jpeg", ".webp", ".gif"}). Value(&file) ``` <img width="600" src="https://vhs.charm.sh/vhs-5DCaCK6WfJGCUuWMjTXLrM.gif" alt="Made with VHS"> *** #### Field Interface ##### Zoom File pickers introduce a new `Zoom` method to the `Field` interface. ```go type Field interface { // ... Zoom() bool // ... } ``` `Zoom` tells the form whether this field should be the only visible field. Notice how the `FilePicker` field zooms in when selecting a file and zooms out when the file is selected, showing only the selected file. ##### Skip Notes introduce a new `Skip` method to the `Field` interface. ```go type Field interface { // ... Skip() bool // ... } ``` Skip indicates to the form whether or not to skip this field, i.e. don't let the user interact with it. This is useful for notes to be purely informational. #### What else? - feat: set `height` in `WithHeight` by [@​ardnew](https://github.com/ardnew) in [https://github.com/charmbracelet/huh/pull/122](https://github.com/charmbracelet/huh/pull/122) - feat: use `EchoMode` for `Input` by [@​caarlos0](https://github.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/131](https://github.com/charmbracelet/huh/pull/131) - feat: zoom `FilePicker` by [@​maaslalani](https://github.com/maaslalani) in [https://github.com/charmbracelet/huh/pull/133](https://github.com/charmbracelet/huh/pull/133) - feat: inline `Select` by [@​maaslalani](https://github.com/maaslalani) in [https://github.com/charmbracelet/huh/pull/136](https://github.com/charmbracelet/huh/pull/136) - feat: <kbd>ctrl+u</kbd>, <kbd>ctrl+d</kbd>, <kbd>g</kbd>, and <kbd>G</kbd> keybindings on `Select` by [@​caarlos0](https://github.com/caarlos0) in [https://github.com/charmbracelet/huh/pull/143](https://github.com/charmbracelet/huh/pull/143) - feat: predefined `ValidationFunc`s by [@​anirudhaCodes](https://github.com/anirudhaCodes) in [https://github.com/charmbracelet/huh/pull/140](https://github.com/charmbracelet/huh/pull/140) - feat: make `PrevField` and `NextField` public by [@​KevM](https://github.com/KevM) in [https://github.com/charmbracelet/huh/pull/175](https://github.com/charmbracelet/huh/pull/175) - feat: accessible mode when `TERM=dumb` by [@​maaslalani](https://github.com/maaslalani) in [https://github.com/charmbracelet/huh/pull/188](https://github.com/charmbracelet/huh/pull/188) - feat: `WithOutput` API by [@​maaslalani](https://github.com/maaslalani) in [https://github.com/charmbracelet/huh/pull/201](https://github.com/charmbracelet/huh/pull/201) - feat: set note next button label by [@​abtmr](https://github.com/abtmr) in [https://github.com/charmbracelet/huh/pull/225](https://github.com/charmbracelet/huh/pull/225) ##### Bug Fixes - fix: overlapping style issue in render function of `field_note` by [@​anirudhaCodes](https://github.com/anirudhaCodes) in [https://github.com/charmbracelet/huh/pull/112](https://github.com/charmbracelet/huh/pull/112) - fix: `MultiSelect` limit in Accessible Mode by [@​anirudhaCodes](https://github.com/anirudhaCodes) in [https://github.com/charmbracelet/huh/pull/125](https://github.com/charmbracelet/huh/pull/125) - fix: CharLimit of `Text` field in Accessible mode by [@​anirudhaCodes](https://github.com/anirudhaCodes) in [https://github.com/charmbracelet/huh/pull/126](https://github.com/charmbracelet/huh/pull/126) - fix: set themes on fields by [@​maaslalani](https://github.com/maaslalani) in [https://github.com/charmbracelet/huh/pull/219](https://github.com/charmbracelet/huh/pull/219) - fix: remove temporary file after opening external editor in `Text` field by [@​auvred](https://github.com/auvred) in [https://github.com/charmbracelet/huh/pull/154](https://github.com/charmbracelet/huh/pull/154) - fix: spinner bubbles up `tea.Program` errors by [@​clowder](https://github.com/clowder) in [https://github.com/charmbracelet/huh/pull/237](https://github.com/charmbracelet/huh/pull/237) #### New Contributors A special thanks to everyone who made this release of Huh? possible! 🤗 - [@​theredditbandit](https://github.com/theredditbandit) made their first contribution in [https://github.com/charmbracelet/huh/pull/102](https://github.com/charmbracelet/huh/pull/102) - [@​anirudhaCodes](https://github.com/anirudhaCodes) made their first contribution in [https://github.com/charmbracelet/huh/pull/112](https://github.com/charmbracelet/huh/pull/112) - [@​rharshit82](https://github.com/rharshit82) made their first contribution in [https://github.com/charmbracelet/huh/pull/128](https://github.com/charmbracelet/huh/pull/128) - [@​stefanlogue](https://github.com/stefanlogue) made their first contribution in [https://github.com/charmbracelet/huh/pull/99](https://github.com/charmbracelet/huh/pull/99) - [@​auvred](https://github.com/auvred) made their first contribution in [https://github.com/charmbracelet/huh/pull/154](https://github.com/charmbracelet/huh/pull/154) - [@​KevM](https://github.com/KevM) made their first contribution in [https://github.com/charmbracelet/huh/pull/175](https://github.com/charmbracelet/huh/pull/175) - [@​zimeg](https://github.com/zimeg) made their first contribution in [https://github.com/charmbracelet/huh/pull/224](https://github.com/charmbracelet/huh/pull/224) - [@​bradyjoslin](https://github.com/bradyjoslin) made their first contribution in [https://github.com/charmbracelet/huh/pull/241](https://github.com/charmbracelet/huh/pull/241) - [@​joshi4](https://github.com/joshi4) made their first contribution in [https://github.com/charmbracelet/huh/pull/232](https://github.com/charmbracelet/huh/pull/232) - [@​abtmr](https://github.com/abtmr) made their first contribution in [https://github.com/charmbracelet/huh/pull/225](https://github.com/charmbracelet/huh/pull/225) - [@​clowder](https://github.com/clowder) made their first contribution in [https://github.com/charmbracelet/huh/pull/237](https://github.com/charmbracelet/huh/pull/237) **Full Changelog**: charmbracelet/huh@v0.3.0...v0.4.0 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.technology/@​charm), or [Slack](https://charm.sh/slack). ### [`v0.4.1`](https://github.com/charmbracelet/huh/compare/v0.4.0...v0.4.1) [Compare Source](https://github.com/charmbracelet/huh/compare/v0.4.0...v0.4.1) ### [`v0.4.0`](https://github.com/charmbracelet/huh/compare/v0.3.0...v0.4.0) [Compare Source](https://github.com/charmbracelet/huh/compare/v0.3.0...v0.4.0) </details> <details> <summary>charmbracelet/lipgloss (github.com/charmbracelet/lipgloss)</summary> ### [`v0.11.0`](https://github.com/charmbracelet/lipgloss/releases/tag/v0.11.0) [Compare Source](https://github.com/charmbracelet/lipgloss/compare/v0.10.0...v0.11.0) ### Immutable Styles and Raw Speed, Baby So! The big news in this release is: - `Style` methods will now *always* return new styles - `Style` and ANSI operations under the hood are faster There are also a handful of great lil' bug fixes. Read on for more. #### Immutable Styles Every `Style` method now returns a completely new style with its own underlying data structure no matter what. This means working with Styles is a lot easier. No more need for `Copy()`! ```go // Before s := lipgloss.NewStyle().Bold(true) newStyle := s.Copy() // After s := lipgloss.NewStyle().Bold(true) newStyle := s // this is a true copy ``` Okay, but why are styles easier to work with now? Consider this: ```go // Before baseStyle := lipgloss.NewStyle().Background(lipgloss.Color("59")) styleAtRuntime := baseStyle.Copy().Width(m.Width) // After baseStyle := lipgloss.NewStyle().Padding(1, 2) styleAtRuntime := baseStyle.Width(m.Width) ``` It might seem small, but eliminating the risk of mutations in persistent styles in an enormous usability improvement. ##### How to upgrade There's nothing to do, however `Style.Copy()` is now deprecated and only returns itself, so you can just remove `Style.Copy()` calls. If you need to *just* copy a style without any changes to it you can simply `b := a`. #### Faster ANSI Sometimes watch companies brag about their "in-house" watch movement. Well, now we're bragging about our in-house-amazing [`x/ansi`](https://github.com/charmbracelet/x/tree/main/ansi) library by our own [@​aymanbagabas](https://github.com/aymanbagabas). It's a fine-tuned, low-level way to manage ANSI sequencing and, because we're pretty nerdy, we’re *super* excited about it. *** #### What's Changed ##### New! - always return copies of styles by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/lipgloss/pull/276](https://github.com/charmbracelet/lipgloss/pull/276) ##### Changed - switch to term/ansi for text manipulation by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/lipgloss/pull/268](https://github.com/charmbracelet/lipgloss/pull/268) - replace stripansi with ansi.Strip in table by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/lipgloss/pull/271](https://github.com/charmbracelet/lipgloss/pull/271) - test for different GOOS & GOARCH by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/lipgloss/pull/292](https://github.com/charmbracelet/lipgloss/pull/292) ##### Fixed - fix combining both conditional and unconditional wrapping by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/lipgloss/pull/275](https://github.com/charmbracelet/lipgloss/pull/275) - fix UnderlineSpaces and StrikethroughSpaces by [@​Taz03](https://github.com/Taz03) in [https://github.com/charmbracelet/lipgloss/pull/299](https://github.com/charmbracelet/lipgloss/pull/299) - always render horizontal border edges when enabled by [@​UnseenBook](https://github.com/UnseenBook) in [https://github.com/charmbracelet/lipgloss/pull/211](https://github.com/charmbracelet/lipgloss/pull/211) - fix possible nil panic by [@​maaslalani](https://github.com/maaslalani) in [https://github.com/charmbracelet/lipgloss/pull/245](https://github.com/charmbracelet/lipgloss/pull/245) - fix transform operating on ANSI sequences by [@​meowgorithm](https://github.com/meowgorithm) in [https://github.com/charmbracelet/lipgloss/pull/274](https://github.com/charmbracelet/lipgloss/pull/274) - change propkeys from int to int64 by [@​hugoleodev](https://github.com/hugoleodev) in [https://github.com/charmbracelet/lipgloss/pull/291](https://github.com/charmbracelet/lipgloss/pull/291) #### New Contributors - [@​benwaffle](https://github.com/benwaffle) made their first contribution in [https://github.com/charmbracelet/lipgloss/pull/247](https://github.com/charmbracelet/lipgloss/pull/247) - [@​UnseenBook](https://github.com/UnseenBook) made their first contribution in [https://github.com/charmbracelet/lipgloss/pull/211](https://github.com/charmbracelet/lipgloss/pull/211) - [@​hugoleodev](https://github.com/hugoleodev) made their first contribution in [https://github.com/charmbracelet/lipgloss/pull/291](https://github.com/charmbracelet/lipgloss/pull/291) - [@​Taz03](https://github.com/Taz03) made their first contribution in [https://github.com/charmbracelet/lipgloss/pull/299](https://github.com/charmbracelet/lipgloss/pull/299) **Full Changelog**: charmbracelet/lipgloss@v0.10.0...v0.11.0 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.technology/@​charm), or [Discord](https://charm.sh/discord). </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* */8 * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jippi/dottie). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODguMSIsInVwZGF0ZWRJblZlciI6IjM3LjM4OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christian Winther <jippignu@gmail.com>
josieang
referenced
this pull request
in josieang/osv-scanner
Jun 6, 2024
](https://renovatebot.com){kind=link}
Renovate + Also Remove/updates some deprecated function calls [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [github.com/BurntSushi/toml](https://github.com/BurntSushi/toml) | `v1.3.2` -> `v1.4.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [github.com/charmbracelet/bubbletea](https://github.com/charmbracelet/bubbletea) | `v0.26.2` -> `v0.26.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/charmbracelet/lipgloss](https://github.com/charmbracelet/lipgloss) | `v0.10.0` -> `v0.11.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | golang.org/x/exp | `9bf2ced` -> `4c93da0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | digest | --- ### Release Notes <details> <summary>BurntSushi/toml (github.com/BurntSushi/toml)</summary> ### [`v1.4.0`](https://github.com/BurntSushi/toml/releases/tag/v1.4.0) [Compare Source](https://github.com/BurntSushi/toml/compare/v1.3.2...v1.4.0) This version requires Go 1.18 - Add toml.Marshal() ([#​405](https://github.com/BurntSushi/toml/issues/405)) - Require 2-digit hour ([#​320](https://github.com/BurntSushi/toml/issues/320)) - Wrap UnmarshalTOML() and UnmarshalText() return values in ParseError for position information ([#​398](https://github.com/BurntSushi/toml/issues/398)) - Fix inline tables with dotted keys inside inline arrays (e.g. `k=[{a.b=1}]`) ([#​400](https://github.com/BurntSushi/toml/issues/400)) </details> <details> <summary>charmbracelet/bubbletea (github.com/charmbracelet/bubbletea)</summary> ### [`v0.26.3`](https://github.com/charmbracelet/bubbletea/releases/tag/v0.26.3) [Compare Source](https://github.com/charmbracelet/bubbletea/compare/v0.26.2...v0.26.3) This is a patch release that prevents `tea.WindowSizeMsg`s from being fired during altscreen changes on Windows. This was due to the fact that Windows emits a `window-size-event` on altscreen changes even if the size hand’t changed. Now, we cache the window-size and compare before sending the message to the `Model`. #### What's Changed - Prevent multiple window-size-events from firing on Windows by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/bubbletea/pull/1021](https://github.com/charmbracelet/bubbletea/pull/1021) - refactor: use x/term and x/ansi for renderer sequences by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/bubbletea/pull/962](https://github.com/charmbracelet/bubbletea/pull/962) **Full Changelog**: charmbracelet/bubbletea@v0.26.2...v0.26.3 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.social/@​charmcli), or [Discord](https://charm.sh/chat). </details> <details> <summary>charmbracelet/lipgloss (github.com/charmbracelet/lipgloss)</summary> ### [`v0.11.0`](https://github.com/charmbracelet/lipgloss/releases/tag/v0.11.0) [Compare Source](https://github.com/charmbracelet/lipgloss/compare/v0.10.0...v0.11.0) ### Immutable Styles and Raw Speed, Baby So! The big news in this release is: - `Style` methods will now *always* return new styles - `Style` and ANSI operations under the hood are faster There are also a handful of great lil' bug fixes. Read on for more. #### Immutable Styles Every `Style` method now returns a completely new style with its own underlying data structure no matter what. This means working with Styles is a lot easier. No more need for `Copy()`! ```go // Before s := lipgloss.NewStyle().Bold(true) newStyle := s.Copy() // After s := lipgloss.NewStyle().Bold(true) newStyle := s // this is a true copy ``` Okay, but why are styles easier to work with now? Consider this: ```go // Before baseStyle := lipgloss.NewStyle().Background(lipgloss.Color("59")) styleAtRuntime := baseStyle.Copy().Width(m.Width) // After baseStyle := lipgloss.NewStyle().Padding(1, 2) styleAtRuntime := baseStyle.Width(m.Width) ``` It might seem small, but eliminating the risk of mutations in persistent styles in an enormous usability improvement. ##### How to upgrade There's nothing to do, however `Style.Copy()` is now deprecated and only returns itself, so you can just remove `Style.Copy()` calls. If you need to *just* copy a style without any changes to it you can simply `b := a`. #### Faster ANSI Sometimes watch companies brag about their "in-house" watch movement. Well, now we're bragging about our in-house-amazing [`x/ansi`](https://github.com/charmbracelet/x/tree/main/ansi) library by our own [@​aymanbagabas](https://github.com/aymanbagabas). It's a fine-tuned, low-level way to manage ANSI sequencing and, because we're pretty nerdy, we’re *super* excited about it. *** #### What's Changed ##### New! - always return copies of styles by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/lipgloss/pull/276](https://github.com/charmbracelet/lipgloss/pull/276) ##### Changed - switch to term/ansi for text manipulation by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/lipgloss/pull/268](https://github.com/charmbracelet/lipgloss/pull/268) - replace stripansi with ansi.Strip in table by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/lipgloss/pull/271](https://github.com/charmbracelet/lipgloss/pull/271) - test for different GOOS & GOARCH by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/lipgloss/pull/292](https://github.com/charmbracelet/lipgloss/pull/292) ##### Fixed - fix combining both conditional and unconditional wrapping by [@​aymanbagabas](https://github.com/aymanbagabas) in [https://github.com/charmbracelet/lipgloss/pull/275](https://github.com/charmbracelet/lipgloss/pull/275) - fix UnderlineSpaces and StrikethroughSpaces by [@​Taz03](https://github.com/Taz03) in [https://github.com/charmbracelet/lipgloss/pull/299](https://github.com/charmbracelet/lipgloss/pull/299) - always render horizontal border edges when enabled by [@​UnseenBook](https://github.com/UnseenBook) in [https://github.com/charmbracelet/lipgloss/pull/211](https://github.com/charmbracelet/lipgloss/pull/211) - fix possible nil panic by [@​maaslalani](https://github.com/maaslalani) in [https://github.com/charmbracelet/lipgloss/pull/245](https://github.com/charmbracelet/lipgloss/pull/245) - fix transform operating on ANSI sequences by [@​meowgorithm](https://github.com/meowgorithm) in [https://github.com/charmbracelet/lipgloss/pull/274](https://github.com/charmbracelet/lipgloss/pull/274) - change propkeys from int to int64 by [@​hugoleodev](https://github.com/hugoleodev) in [https://github.com/charmbracelet/lipgloss/pull/291](https://github.com/charmbracelet/lipgloss/pull/291) #### New Contributors - [@​benwaffle](https://github.com/benwaffle) made their first contribution in [https://github.com/charmbracelet/lipgloss/pull/247](https://github.com/charmbracelet/lipgloss/pull/247) - [@​UnseenBook](https://github.com/UnseenBook) made their first contribution in [https://github.com/charmbracelet/lipgloss/pull/211](https://github.com/charmbracelet/lipgloss/pull/211) - [@​hugoleodev](https://github.com/hugoleodev) made their first contribution in [https://github.com/charmbracelet/lipgloss/pull/291](https://github.com/charmbracelet/lipgloss/pull/291) - [@​Taz03](https://github.com/Taz03) made their first contribution in [https://github.com/charmbracelet/lipgloss/pull/299](https://github.com/charmbracelet/lipgloss/pull/299) **Full Changelog**: charmbracelet/lipgloss@v0.10.0...v0.11.0 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.technology/@​charm), or [Discord](https://charm.sh/discord). </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==--> --------- Co-authored-by: Rex P <rexpan@google.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an int to store property existence and style struct fields to store the actual values for each non-bool property.
Fixes: #139
Fixes: #141